Page MenuHomePhabricator

[chore] clean up more services stuff
ClosedPublic

Authored by varun on Jun 27 2023, 8:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 7:59 PM
Unknown Object (File)
Fri, Nov 22, 9:04 PM
Unknown Object (File)
Fri, Nov 8, 6:58 PM
Unknown Object (File)
Fri, Nov 8, 3:52 PM
Unknown Object (File)
Fri, Nov 8, 3:37 PM
Unknown Object (File)
Fri, Nov 8, 1:50 AM
Unknown Object (File)
Fri, Nov 8, 1:43 AM
Unknown Object (File)
Fri, Nov 8, 1:30 AM
Subscribers

Details

Summary

bunch of unused files and scripts. removed them and references to them.

Depends on D8334

Test Plan

see if CI passes

Diff Detail

Repository
rCOMM Comm
Branch
remove-unused-shared (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun requested review of this revision.Jun 27 2023, 9:05 AM
atul added 2 blocking reviewer(s): ashoat, jon.

Looks reasonable, would be good to get @jon and @ashoat's sign-off since they have more context on services.

Yea, this looks right to me

Blob and backup services' docker images still use base-image- I remember I couldn't get protobuf working when using rust as the base image.
I need to try again now.

Technically, it uses the dockerhub image (and won't likely rebuild it soon) so it won't break anything but just FYI

Blob and backup services' docker images still use base-image- I remember I couldn't get protobuf working when using rust as the base image.
I need to try again now.

Technically, it uses the dockerhub image (and won't likely rebuild it soon) so it won't break anything but just FYI

yeah i saw that. for identity we use the install_protobuf script and rust base image and it works fine. should be the same for blob and backup i imagine

In D8336#246363, @varun wrote:

for identity we use the install_protobuf script and rust base image and it works fine. should be the same for blob and backup i imagine

Yeah that's the part that didn't work for me then. Anyway, it should work now so I'll try again. Don't feel blocked on this

I'm not super familiar with the services codebase

This revision is now accepted and ready to land.Jun 28 2023, 6:29 PM
This revision was automatically updated to reflect the committed changes.