Paths

Table of Contentst

Differential D8336

[chore] clean up more services stuff
ClosedPublic
Actions

Authored by varun on Jun 27 2023, 8:47 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 6, 5:44 PM

	Unknown Object (File)
	Wed, Apr 2, 8:26 AM

	Unknown Object (File)
	Thu, Mar 27, 5:30 AM

	Unknown Object (File)
	Mon, Mar 17, 8:47 AM

	Unknown Object (File)
	Mon, Mar 10, 8:09 PM

	Unknown Object (File)
	Mon, Mar 10, 8:09 PM

	Unknown Object (File)
	Mon, Mar 10, 7:52 PM

	Unknown Object (File)
	Mon, Mar 10, 7:49 PM

View All 98 Files

Subscribers

Details

Reviewers

atul
• jon
ashoat

Commits

rCOMMe1e134b904fa: [chore] clean up more services stuff

Summary

bunch of unused files and scripts. removed them and references to them.

Depends on D8334

Test Plan

see if CI passes

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jun 27 2023, 8:47 AM

Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2023, 8:47 AM

Harbormaster completed remote builds in B20550: Diff 28183.Jun 27 2023, 9:05 AM

varun requested review of this revision.Jun 27 2023, 9:05 AM

Looks reasonable, would be good to get @jon and @ashoat's sign-off since they have more context on services.

Yea, this looks right to me

varun mentioned this in D8244: [services] Delete shared C++ lib.Jun 28 2023, 12:25 PM

Blob and backup services' docker images still use base-image- I remember I couldn't get protobuf working when using rust as the base image.
I need to try again now.

Technically, it uses the dockerhub image (and won't likely rebuild it soon) so it won't break anything but just FYI

In D8336#246362, @bartek wrote:

Blob and backup services' docker images still use base-image- I remember I couldn't get protobuf working when using rust as the base image.
I need to try again now.

Technically, it uses the dockerhub image (and won't likely rebuild it soon) so it won't break anything but just FYI

yeah i saw that. for identity we use the install_protobuf script and rust base image and it works fine. should be the same for blob and backup i imagine

In D8336#246363, @varun wrote:

for identity we use the install_protobuf script and rust base image and it works fine. should be the same for blob and backup i imagine

Yeah that's the part that didn't work for me then. Anyway, it should work now so I'll try again. Don't feel blocked on this

I'm not super familiar with the services codebase

This revision is now accepted and ready to land.Jun 28 2023, 6:29 PM

Closed by commit rCOMMe1e134b904fa: [chore] clean up more services stuff (authored by varun). · Explain WhyJun 29 2023, 8:09 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMe1e134b904fa: [chore] clean up more services stuff.

Revision Contents
Changeset List

Path

Size

5 lines

services/

lib/

cmake-components/

docker/

build_service.sh

build_sources.sh

install_corrosion.sh

proto_codegen.sh

src/

DatabaseEntitiesTools.h

DatabaseManagerBase.h

DatabaseManagerBase.cpp

DynamoDBTools.h

DynamoDBTools.cpp

GlobalConstants.h

GlobalTools.cpp

ReactorStatusHolder.h

client-base-reactors/

ClientBidiReactorBase.h

ClientReadReactorBase.h

ClientWriteReactorBase.h

server-base-reactors/

ServerBidiReactorBase.h

ServerReadReactorBase.h

ServerWriteReactorBase.h

5 lines

scripts/

build_base_image.sh

list_services.sh

2 lines

Diff 28269

.dockerignore

	Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines		class CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
	jsi::Value getUserPublicKey(jsi::Runtime &rt) override;			jsi::Value getUserPublicKey(jsi::Runtime &rt) override;
	jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;			jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;
	jsi::Object			jsi::Object
	openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;			openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
	double getCodeVersion(jsi::Runtime &rt) override;			double getCodeVersion(jsi::Runtime &rt) override;
	jsi::Value			jsi::Value
	setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;			setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
	jsi::Value clearNotifyToken(jsi::Runtime &rt) override;			jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
				void clearSensitiveData(jsi::Runtime &rt) override;

	public:			public:
	CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);			CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);

	void initializeNetworkModule(			void initializeNetworkModule(
	const std::string &userId,			const std::string &userId,
	const std::string &deviceToken,			const std::string &deviceToken,
	const std::string &hostname = "");			const std::string &hostname = "");
	};			};

	} // namespace comm			} // namespace comm

services/lib/cmake-components/folly.cmake

	Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines		class CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
	jsi::Value getUserPublicKey(jsi::Runtime &rt) override;			jsi::Value getUserPublicKey(jsi::Runtime &rt) override;
	jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;			jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;
	jsi::Object			jsi::Object
	openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;			openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
	double getCodeVersion(jsi::Runtime &rt) override;			double getCodeVersion(jsi::Runtime &rt) override;
	jsi::Value			jsi::Value
	setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;			setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
	jsi::Value clearNotifyToken(jsi::Runtime &rt) override;			jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
				void clearSensitiveData(jsi::Runtime &rt) override;

	public:			public:
	CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);			CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);

	void initializeNetworkModule(			void initializeNetworkModule(
	const std::string &userId,			const std::string &userId,
	const std::string &deviceToken,			const std::string &deviceToken,
	const std::string &hostname = "");			const std::string &hostname = "");
	};			};

	} // namespace comm			} // namespace comm

services/lib/cmake-components/grpc.cmake

	Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines		class CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
	jsi::Value getUserPublicKey(jsi::Runtime &rt) override;			jsi::Value getUserPublicKey(jsi::Runtime &rt) override;
	jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;			jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;
	jsi::Object			jsi::Object
	openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;			openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
	double getCodeVersion(jsi::Runtime &rt) override;			double getCodeVersion(jsi::Runtime &rt) override;
	jsi::Value			jsi::Value
	setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;			setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
	jsi::Value clearNotifyToken(jsi::Runtime &rt) override;			jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
				void clearSensitiveData(jsi::Runtime &rt) override;

	public:			public:
	CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);			CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);

	void initializeNetworkModule(			void initializeNetworkModule(
	const std::string &userId,			const std::string &userId,
	const std::string &deviceToken,			const std::string &deviceToken,
	const std::string &hostname = "");			const std::string &hostname = "");
	};			};

	} // namespace comm			} // namespace comm

services/lib/docker/build_service.sh

	Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines		class CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
	jsi::Value getUserPublicKey(jsi::Runtime &rt) override;			jsi::Value getUserPublicKey(jsi::Runtime &rt) override;
	jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;			jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;
	jsi::Object			jsi::Object
	openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;			openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
	double getCodeVersion(jsi::Runtime &rt) override;			double getCodeVersion(jsi::Runtime &rt) override;
	jsi::Value			jsi::Value
	setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;			setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
	jsi::Value clearNotifyToken(jsi::Runtime &rt) override;			jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
				void clearSensitiveData(jsi::Runtime &rt) override;

	public:			public:
	CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);			CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);

	void initializeNetworkModule(			void initializeNetworkModule(
	const std::string &userId,			const std::string &userId,
	const std::string &deviceToken,			const std::string &deviceToken,
	const std::string &hostname = "");			const std::string &hostname = "");
	};			};

	} // namespace comm			} // namespace comm

services/lib/docker/build_sources.sh

Loading...

services/lib/docker/install_corrosion.sh

Loading...

services/lib/docker/proto_codegen.sh

Loading...

services/lib/docker/run_service.sh

Loading...

services/lib/docker/run_tests.sh

Loading...

services/lib/src/BaseReactor.h

Loading...

services/lib/src/CMakeLists.txt

Loading...

services/lib/src/DatabaseEntitiesTools.h

Loading...

services/lib/src/DatabaseManagerBase.h

Loading...

services/lib/src/DatabaseManagerBase.cpp

Loading...

services/lib/src/DynamoDBTools.h

Loading...

services/lib/src/DynamoDBTools.cpp

Loading...

services/lib/src/GlobalConstants.h

Loading...

services/lib/src/GlobalTools.h

Loading...

services/lib/src/GlobalTools.cpp

Loading...

services/lib/src/Item.h

Loading...

services/lib/src/ReactorStatusHolder.h

Loading...

services/lib/src/ThreadPool.h

Loading...

services/lib/src/client-base-reactors/CMakeLists.txt

Loading...

services/lib/src/client-base-reactors/ClientBidiReactorBase.h

Loading...

services/lib/src/client-base-reactors/ClientReadReactorBase.h

Loading...

services/lib/src/client-base-reactors/ClientWriteReactorBase.h

Loading...

services/lib/src/server-base-reactors/CMakeLists.txt

Loading...

services/lib/src/server-base-reactors/ServerBidiReactorBase.h

Loading...

services/lib/src/server-base-reactors/ServerReadReactorBase.h

Loading...

services/lib/src/server-base-reactors/ServerWriteReactorBase.h

Loading...

services/package.json

Loading...

services/scripts/build_base_image.sh

Loading...

services/scripts/list_services.sh

Loading...