Paths

Table of Contentst

[native] remove rust related methods from CommCoreModule
ClosedPublic
Actions

Authored by kamil on Jul 28 2023, 4:38 PM.

Details

Reviewers

bartek
michal
tomek
varun

Commits

rCOMM88c14d6a5c3a: [native] remove rust related methods from CommCoreModule

Summary

ENG-4232

Creating a separate module for Rust API. This is a part of CommCoreModule refactor.

This API was moved to CommRustModule.

Test Plan

Build Android and iOS

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 28 2023, 4:38 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 28 2023, 4:38 PM

Harbormaster completed remote builds in B21306: Diff 29182.Jul 28 2023, 4:55 PM

kamil added a parent revision: D8658: [native] install CommRustModule.Jul 28 2023, 4:56 PM

kamil published this revision for review.Jul 28 2023, 5:21 PM

bartek accepted this revision.Jul 31 2023, 9:48 AM

This revision is now accepted and ready to land.Jul 31 2023, 9:48 AM

rebase

Harbormaster completed remote builds in B21379: Diff 29291.Jul 31 2023, 5:40 PM

Closed by commit rCOMM88c14d6a5c3a: [native] remove rust related methods from CommCoreModule. · Explain WhyAug 1 2023, 9:17 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM88c14d6a5c3a: [native] remove rust related methods from CommCoreModule.

kamil mentioned this in D10449: [native] Expose get keyserver keys Identity RPC.Jan 3 2024, 8:25 AM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.h

39 lines

CommCoreModule.cpp

162 lines

_generated/

commJSI-generated.cpp

commJSI.h

schema/

CommCoreModuleSchema.js

38 lines

Diff 29414

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI.h

View Options

native/schema/CommCoreModuleSchema.js

[native] remove rust related methods from CommCoreModuleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29414

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

native/cpp/CommonCpp/_generated/commJSI.h

native/schema/CommCoreModuleSchema.js

[native] remove rust related methods from CommCoreModule
ClosedPublic
Actions

Revision Contents
Changeset List