Paths

Table of Contentst

[native] install CommRustModule
ClosedPublic
Actions

Authored by kamil on Jul 28 2023, 9:55 AM.

Details

Reviewers

bartek
michal
tomek
varun

Commits

rCOMM9ef783dfd079: [native] install CommRustModule

Summary

ENG-4232

Creating a separate module for Rust API. This is a part of CommCoreModule refactor.

Code to install new module for both iOS and Android.

Depends on D8657

Test Plan

Build Android nad iOS
On iOS added test generateNonce to make sure Rust methods are callable. Inspired by test plan from D7215.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 28 2023, 9:55 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 28 2023, 9:55 AM

kamil added a child revision: D8654: [native] remove rust related methods from CommCoreModule.Jul 28 2023, 9:56 AM

kamil published this revision for review.Jul 28 2023, 10:21 AM

Harbormaster completed remote builds in B21310: Diff 29186.Jul 28 2023, 10:30 AM

bartek accepted this revision.Jul 31 2023, 2:47 AM

This revision is now accepted and ready to land.Jul 31 2023, 2:47 AM

rebase

Harbormaster completed remote builds in B21378: Diff 29290.Jul 31 2023, 10:27 AM

Closed by commit rCOMM9ef783dfd079: [native] install CommRustModule (authored by kamil). · Explain WhyAug 1 2023, 2:17 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM9ef783dfd079: [native] install CommRustModule.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

src/

cpp/

jsiInstaller.cpp

7 lines

ios/

Comm/

AppDelegate.mm

7 lines

native-modules.js

2 lines

Diff 29413

View Options

native/android/app/src/cpp/jsiInstaller.cpp

View Options

native/ios/Comm/AppDelegate.mm

View Options

[native] install CommRustModuleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29413

native/android/app/src/cpp/jsiInstaller.cpp

native/ios/Comm/AppDelegate.mm

native/native-modules.js

[native] install CommRustModule
ClosedPublic
Actions

Revision Contents
Changeset List