Page MenuHomePhabricator
Differential D8656

[native] generate C++ spec for CommRustModule
ClosedPublic
Actions

Authored by kamil on Jul 28 2023, 9:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 3:14 AM
Unknown Object (File)
Tue, Mar 18, 9:24 AM
Unknown Object (File)
Sat, Mar 15, 1:56 PM
Unknown Object (File)
Wed, Mar 12, 1:35 PM
Unknown Object (File)
Feb 22 2025, 1:53 PM
Unknown Object (File)
Feb 22 2025, 1:53 PM
Unknown Object (File)
Feb 22 2025, 1:53 PM
Unknown Object (File)
Feb 22 2025, 1:53 PM
View All Files
Subscribers
ashoat

Details

Reviewers
bartek
michal
tomek
varun
Commits
rCOMM7d6853161f4e: [native] generate C++ spec for CommRustModule
Summary

ENG-4232

Creating a separate module for Rust API. This is a part of CommCoreModule refactor.

Make codegen generate C++ for module.

Depends on D8655

Test Plan

run codegen-jsi

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jul 28 2023, 9:47 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 28 2023, 9:47 AM
kamil added a child revision: D8657: [native] add CommRustModule implementation.Jul 28 2023, 9:54 AM
Harbormaster failed remote builds in B21308: Diff 29184!Jul 28 2023, 10:10 AM
kamil published this revision for review.Jul 28 2023, 10:20 AM
bartek accepted this revision.Jul 31 2023, 2:46 AM
This revision is now accepted and ready to land.Jul 31 2023, 2:46 AM
kamil updated this revision to Diff 29288.Jul 31 2023, 8:50 AM

rebase

Harbormaster failed remote builds in B21376: Diff 29288!Jul 31 2023, 9:56 AM
kamil updated this revision to Diff 29296.Jul 31 2023, 10:05 AM

fix dependencies (I messed up while resolving conflicts)

Harbormaster completed remote builds in B21384: Diff 29296.Jul 31 2023, 11:44 AM
Closed by commit rCOMM7d6853161f4e: [native] generate C++ spec for CommRustModule (authored by kamil). · Explain WhyAug 1 2023, 2:17 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM7d6853161f4e: [native] generate C++ spec for CommRustModule.

Revision Contents
Changeset List

PathSize
native/
android/
app/
1 line
codegen/
src/
4 lines
cpp/
CommonCpp/
_generated/
ios/
Comm.xcodeproj/
6 lines

Diff 29411

View Options

native/android/app/CMakeLists.txt

  • This file was moved to services/lib/src/DatabaseEntitiesTools.h.
View Options

native/codegen/src/index.js

  • This file was moved to services/lib/src/DatabaseEntitiesTools.h.
View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

  • This file was moved to services/lib/src/DatabaseEntitiesTools.h.
View Options

native/cpp/CommonCpp/_generated/rustJSI.h

  • This file was moved to services/lib/src/DatabaseEntitiesTools.h.
View Options

native/ios/Comm.xcodeproj/project.pbxproj

  • This file was moved to services/lib/src/DatabaseEntitiesTools.h.