Page MenuHomePhabricator
Differential D8656

[native] generate C++ spec for CommRustModule
ClosedPublic
Actions

Authored by kamil on Jul 28 2023, 9:47 AM.
Tags
None
Referenced Files
F5976478: D8656.id29288.diff
Sat, Apr 19, 12:51 AM
Unknown Object (File)
Wed, Apr 9, 1:06 AM
Unknown Object (File)
Tue, Apr 8, 11:21 PM
Unknown Object (File)
Tue, Apr 8, 10:38 PM
Unknown Object (File)
Tue, Apr 8, 9:35 PM
Unknown Object (File)
Tue, Apr 8, 9:18 PM
Unknown Object (File)
Sat, Apr 5, 12:07 PM
Unknown Object (File)
Thu, Mar 20, 3:14 AM
View All Files
Subscribers
ashoat

Details

Reviewers
bartek
michal
tomek
varun
Commits
rCOMM7d6853161f4e: [native] generate C++ spec for CommRustModule
Summary

ENG-4232

Creating a separate module for Rust API. This is a part of CommCoreModule refactor.

Make codegen generate C++ for module.

Depends on D8655

Test Plan

run codegen-jsi

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jul 28 2023, 9:47 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 28 2023, 9:47 AM
kamil added a child revision: D8657: [native] add CommRustModule implementation.Jul 28 2023, 9:54 AM
Harbormaster failed remote builds in B21308: Diff 29184!Jul 28 2023, 10:10 AM
kamil published this revision for review.Jul 28 2023, 10:20 AM
bartek accepted this revision.Jul 31 2023, 2:46 AM
This revision is now accepted and ready to land.Jul 31 2023, 2:46 AM
kamil updated this revision to Diff 29288.Jul 31 2023, 8:50 AM

rebase

Harbormaster failed remote builds in B21376: Diff 29288!Jul 31 2023, 9:56 AM
kamil updated this revision to Diff 29296.Jul 31 2023, 10:05 AM

fix dependencies (I messed up while resolving conflicts)

Harbormaster completed remote builds in B21384: Diff 29296.Jul 31 2023, 11:44 AM
Closed by commit rCOMM7d6853161f4e: [native] generate C++ spec for CommRustModule (authored by kamil). · Explain WhyAug 1 2023, 2:17 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM7d6853161f4e: [native] generate C++ spec for CommRustModule.

Revision Contents
Changeset List

PathSize
native/
android/
app/
1 line
codegen/
src/
4 lines
cpp/
CommonCpp/
_generated/
ios/
Comm.xcodeproj/
6 lines

Diff 29411

View Options

native/android/app/CMakeLists.txt

#!/usr/bin/env bash #!/usr/bin/env bash
# Check if shell is using a default BSD or GNU prompt
if [[ ${PS1} != '\s-\v\$'* ]] && \
[[ ${PS1} != '%n@%m %1~ %#'* ]]; then
# User already has an opinionated PS1, just leave
return 0
fi
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
COMM_CACHE="${XDG_CACHE_HOME:-$HOME/Library/Caches}/app.comm" COMM_CACHE="${XDG_CACHE_HOME:-$HOME/Library/Caches}/app.comm"
else else
COMM_CACHE="${XDG_CACHE_HOME:-$HOME/.cache}/comm" COMM_CACHE="${XDG_CACHE_HOME:-$HOME/.cache}/comm"
fi fi
COMM_EMITTED_WARNING="$COMM_CACHE/powerline_warning" mkdir -p "$COMM_CACHE"
COMM_POWERLINE="$COMM_CACHE/enable-powerline"
# Only emit this the first time, as it's suprising to the user for the prompt # Only emit this the first time, as it's suprising to the user for the prompt
# to be replaced, but avoid emitting the warning on subsequent invocations # to be replaced, but avoid emitting the warning on subsequent invocations
if [[ ! -f "$COMM_EMITTED_WARNING" ]]; then if [[ ! -e "${COMM_POWERLINE}" ]]; then
echo "Default prompt found, attempting to enable powerline" >&2 read -r \
-p "Would you like to enable Powerline as the default bash prompt? [y/N] " \
response
case "$response" in
[yY][eE][sS]|[yY])
echo "1" > "${COMM_POWERLINE}"
;;
*)
touch "${COMM_POWERLINE}"
;;
esac
fi
# Create file to ensure it exists for next time this is run # If empty, user want's to use native prompt
mkdir -p "$COMM_CACHE" if [[ ! -s "${COMM_POWERLINE}" ]]; then
touch "$COMM_EMITTED_WARNING" return 0
fi fi
# Check if the powerline fonts are installed # Check if the powerline fonts are installed
# If the font is missing then many of the glyphs will render as ? # If the font is missing then many of the glyphs will render as ?
# Adapted from https://github.com/powerline/fonts/blob/master/install.sh # Adapted from https://github.com/powerline/fonts/blob/master/install.sh
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
# MacOS # MacOS
font_dir="$HOME/Library/Fonts" font_dir="$HOME/Library/Fonts"
else else
# Linux # Linux
font_dir="${XDG_DATA_HOME:-$HOME/.local/share}/fonts" font_dir="${XDG_DATA_HOME:-$HOME/.local/share}/fonts"
mkdir -p "$font_dir" mkdir -p "$font_dir"
fi fi
if [[ ! -f "$font_dir/Droid Sans Mono for Powerline.otf" ]]; then if [[ ! -f "$font_dir/Droid Sans Mono for Powerline.otf" ]]; then
if [[ ! -d "${powerline_fonts:-/doesnt-exist}" ]]; then if [[ ! -d "${powerline_fonts:-/doesnt-exist}" ]]; then
echo "Unable to determine powerline fonts location" >&2 echo "Unable to determine powerline fonts location" >&2
return 1 return 1
fi fi
echo "Installing powerline fonts" >&2 echo "Installing Powerline fonts" >&2
find "$powerline_fonts" \ find "$powerline_fonts" \
\( -name "*.[ot]tf" -or -name "*.pcf.gz" \) -type f -print0 \ \( -name "*.[ot]tf" -or -name "*.pcf.gz" \) -type f -print0 \
| xargs -0 -n1 -I % cp "%" "$font_dir/" | xargs -0 -n1 -I % cp "%" "$font_dir/"
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
if [[ "$TERM_PROGRAM" == "Apple_Terminal" ]]; then if [[ "$TERM_PROGRAM" == "Apple_Terminal" ]]; then
echo "For glyph support, please: echo "For glyph support, please:
Show All 17 Lines
View Options

native/codegen/src/index.js

#!/usr/bin/env bash #!/usr/bin/env bash
# Check if shell is using a default BSD or GNU prompt
if [[ ${PS1} != '\s-\v\$'* ]] && \
[[ ${PS1} != '%n@%m %1~ %#'* ]]; then
# User already has an opinionated PS1, just leave
return 0
fi
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
COMM_CACHE="${XDG_CACHE_HOME:-$HOME/Library/Caches}/app.comm" COMM_CACHE="${XDG_CACHE_HOME:-$HOME/Library/Caches}/app.comm"
else else
COMM_CACHE="${XDG_CACHE_HOME:-$HOME/.cache}/comm" COMM_CACHE="${XDG_CACHE_HOME:-$HOME/.cache}/comm"
fi fi
COMM_EMITTED_WARNING="$COMM_CACHE/powerline_warning" mkdir -p "$COMM_CACHE"
COMM_POWERLINE="$COMM_CACHE/enable-powerline"
# Only emit this the first time, as it's suprising to the user for the prompt # Only emit this the first time, as it's suprising to the user for the prompt
# to be replaced, but avoid emitting the warning on subsequent invocations # to be replaced, but avoid emitting the warning on subsequent invocations
if [[ ! -f "$COMM_EMITTED_WARNING" ]]; then if [[ ! -e "${COMM_POWERLINE}" ]]; then
echo "Default prompt found, attempting to enable powerline" >&2 read -r \
-p "Would you like to enable Powerline as the default bash prompt? [y/N] " \
response
case "$response" in
[yY][eE][sS]|[yY])
echo "1" > "${COMM_POWERLINE}"
;;
*)
touch "${COMM_POWERLINE}"
;;
esac
fi
# Create file to ensure it exists for next time this is run # If empty, user want's to use native prompt
mkdir -p "$COMM_CACHE" if [[ ! -s "${COMM_POWERLINE}" ]]; then
touch "$COMM_EMITTED_WARNING" return 0
fi fi
# Check if the powerline fonts are installed # Check if the powerline fonts are installed
# If the font is missing then many of the glyphs will render as ? # If the font is missing then many of the glyphs will render as ?
# Adapted from https://github.com/powerline/fonts/blob/master/install.sh # Adapted from https://github.com/powerline/fonts/blob/master/install.sh
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
# MacOS # MacOS
font_dir="$HOME/Library/Fonts" font_dir="$HOME/Library/Fonts"
else else
# Linux # Linux
font_dir="${XDG_DATA_HOME:-$HOME/.local/share}/fonts" font_dir="${XDG_DATA_HOME:-$HOME/.local/share}/fonts"
mkdir -p "$font_dir" mkdir -p "$font_dir"
fi fi
if [[ ! -f "$font_dir/Droid Sans Mono for Powerline.otf" ]]; then if [[ ! -f "$font_dir/Droid Sans Mono for Powerline.otf" ]]; then
if [[ ! -d "${powerline_fonts:-/doesnt-exist}" ]]; then if [[ ! -d "${powerline_fonts:-/doesnt-exist}" ]]; then
echo "Unable to determine powerline fonts location" >&2 echo "Unable to determine powerline fonts location" >&2
return 1 return 1
fi fi
echo "Installing powerline fonts" >&2 echo "Installing Powerline fonts" >&2
find "$powerline_fonts" \ find "$powerline_fonts" \
\( -name "*.[ot]tf" -or -name "*.pcf.gz" \) -type f -print0 \ \( -name "*.[ot]tf" -or -name "*.pcf.gz" \) -type f -print0 \
| xargs -0 -n1 -I % cp "%" "$font_dir/" | xargs -0 -n1 -I % cp "%" "$font_dir/"
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
if [[ "$TERM_PROGRAM" == "Apple_Terminal" ]]; then if [[ "$TERM_PROGRAM" == "Apple_Terminal" ]]; then
echo "For glyph support, please: echo "For glyph support, please:
Show All 17 Lines
View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

#!/usr/bin/env bash #!/usr/bin/env bash
# Check if shell is using a default BSD or GNU prompt
if [[ ${PS1} != '\s-\v\$'* ]] && \
[[ ${PS1} != '%n@%m %1~ %#'* ]]; then
# User already has an opinionated PS1, just leave
return 0
fi
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
COMM_CACHE="${XDG_CACHE_HOME:-$HOME/Library/Caches}/app.comm" COMM_CACHE="${XDG_CACHE_HOME:-$HOME/Library/Caches}/app.comm"
else else
COMM_CACHE="${XDG_CACHE_HOME:-$HOME/.cache}/comm" COMM_CACHE="${XDG_CACHE_HOME:-$HOME/.cache}/comm"
fi fi
COMM_EMITTED_WARNING="$COMM_CACHE/powerline_warning" mkdir -p "$COMM_CACHE"
COMM_POWERLINE="$COMM_CACHE/enable-powerline"
# Only emit this the first time, as it's suprising to the user for the prompt # Only emit this the first time, as it's suprising to the user for the prompt
# to be replaced, but avoid emitting the warning on subsequent invocations # to be replaced, but avoid emitting the warning on subsequent invocations
if [[ ! -f "$COMM_EMITTED_WARNING" ]]; then if [[ ! -e "${COMM_POWERLINE}" ]]; then
echo "Default prompt found, attempting to enable powerline" >&2 read -r \
-p "Would you like to enable Powerline as the default bash prompt? [y/N] " \
response
case "$response" in
[yY][eE][sS]|[yY])
echo "1" > "${COMM_POWERLINE}"
;;
*)
touch "${COMM_POWERLINE}"
;;
esac
fi
# Create file to ensure it exists for next time this is run # If empty, user want's to use native prompt
mkdir -p "$COMM_CACHE" if [[ ! -s "${COMM_POWERLINE}" ]]; then
touch "$COMM_EMITTED_WARNING" return 0
fi fi
# Check if the powerline fonts are installed # Check if the powerline fonts are installed
# If the font is missing then many of the glyphs will render as ? # If the font is missing then many of the glyphs will render as ?
# Adapted from https://github.com/powerline/fonts/blob/master/install.sh # Adapted from https://github.com/powerline/fonts/blob/master/install.sh
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
# MacOS # MacOS
font_dir="$HOME/Library/Fonts" font_dir="$HOME/Library/Fonts"
else else
# Linux # Linux
font_dir="${XDG_DATA_HOME:-$HOME/.local/share}/fonts" font_dir="${XDG_DATA_HOME:-$HOME/.local/share}/fonts"
mkdir -p "$font_dir" mkdir -p "$font_dir"
fi fi
if [[ ! -f "$font_dir/Droid Sans Mono for Powerline.otf" ]]; then if [[ ! -f "$font_dir/Droid Sans Mono for Powerline.otf" ]]; then
if [[ ! -d "${powerline_fonts:-/doesnt-exist}" ]]; then if [[ ! -d "${powerline_fonts:-/doesnt-exist}" ]]; then
echo "Unable to determine powerline fonts location" >&2 echo "Unable to determine powerline fonts location" >&2
return 1 return 1
fi fi
echo "Installing powerline fonts" >&2 echo "Installing Powerline fonts" >&2
find "$powerline_fonts" \ find "$powerline_fonts" \
\( -name "*.[ot]tf" -or -name "*.pcf.gz" \) -type f -print0 \ \( -name "*.[ot]tf" -or -name "*.pcf.gz" \) -type f -print0 \
| xargs -0 -n1 -I % cp "%" "$font_dir/" | xargs -0 -n1 -I % cp "%" "$font_dir/"
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
if [[ "$TERM_PROGRAM" == "Apple_Terminal" ]]; then if [[ "$TERM_PROGRAM" == "Apple_Terminal" ]]; then
echo "For glyph support, please: echo "For glyph support, please:
Show All 17 Lines
View Options

native/cpp/CommonCpp/_generated/rustJSI.h

#!/usr/bin/env bash #!/usr/bin/env bash
# Check if shell is using a default BSD or GNU prompt
if [[ ${PS1} != '\s-\v\$'* ]] && \
[[ ${PS1} != '%n@%m %1~ %#'* ]]; then
# User already has an opinionated PS1, just leave
return 0
fi
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
COMM_CACHE="${XDG_CACHE_HOME:-$HOME/Library/Caches}/app.comm" COMM_CACHE="${XDG_CACHE_HOME:-$HOME/Library/Caches}/app.comm"
else else
COMM_CACHE="${XDG_CACHE_HOME:-$HOME/.cache}/comm" COMM_CACHE="${XDG_CACHE_HOME:-$HOME/.cache}/comm"
fi fi
COMM_EMITTED_WARNING="$COMM_CACHE/powerline_warning" mkdir -p "$COMM_CACHE"
COMM_POWERLINE="$COMM_CACHE/enable-powerline"
# Only emit this the first time, as it's suprising to the user for the prompt # Only emit this the first time, as it's suprising to the user for the prompt
# to be replaced, but avoid emitting the warning on subsequent invocations # to be replaced, but avoid emitting the warning on subsequent invocations
if [[ ! -f "$COMM_EMITTED_WARNING" ]]; then if [[ ! -e "${COMM_POWERLINE}" ]]; then
echo "Default prompt found, attempting to enable powerline" >&2 read -r \
-p "Would you like to enable Powerline as the default bash prompt? [y/N] " \
response
case "$response" in
[yY][eE][sS]|[yY])
echo "1" > "${COMM_POWERLINE}"
;;
*)
touch "${COMM_POWERLINE}"
;;
esac
fi
# Create file to ensure it exists for next time this is run # If empty, user want's to use native prompt
mkdir -p "$COMM_CACHE" if [[ ! -s "${COMM_POWERLINE}" ]]; then
touch "$COMM_EMITTED_WARNING" return 0
fi fi
# Check if the powerline fonts are installed # Check if the powerline fonts are installed
# If the font is missing then many of the glyphs will render as ? # If the font is missing then many of the glyphs will render as ?
# Adapted from https://github.com/powerline/fonts/blob/master/install.sh # Adapted from https://github.com/powerline/fonts/blob/master/install.sh
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
# MacOS # MacOS
font_dir="$HOME/Library/Fonts" font_dir="$HOME/Library/Fonts"
else else
# Linux # Linux
font_dir="${XDG_DATA_HOME:-$HOME/.local/share}/fonts" font_dir="${XDG_DATA_HOME:-$HOME/.local/share}/fonts"
mkdir -p "$font_dir" mkdir -p "$font_dir"
fi fi
if [[ ! -f "$font_dir/Droid Sans Mono for Powerline.otf" ]]; then if [[ ! -f "$font_dir/Droid Sans Mono for Powerline.otf" ]]; then
if [[ ! -d "${powerline_fonts:-/doesnt-exist}" ]]; then if [[ ! -d "${powerline_fonts:-/doesnt-exist}" ]]; then
echo "Unable to determine powerline fonts location" >&2 echo "Unable to determine powerline fonts location" >&2
return 1 return 1
fi fi
echo "Installing powerline fonts" >&2 echo "Installing Powerline fonts" >&2
find "$powerline_fonts" \ find "$powerline_fonts" \
\( -name "*.[ot]tf" -or -name "*.pcf.gz" \) -type f -print0 \ \( -name "*.[ot]tf" -or -name "*.pcf.gz" \) -type f -print0 \
| xargs -0 -n1 -I % cp "%" "$font_dir/" | xargs -0 -n1 -I % cp "%" "$font_dir/"
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
if [[ "$TERM_PROGRAM" == "Apple_Terminal" ]]; then if [[ "$TERM_PROGRAM" == "Apple_Terminal" ]]; then
echo "For glyph support, please: echo "For glyph support, please:
Show All 17 Lines
View Options

native/ios/Comm.xcodeproj/project.pbxproj

#!/usr/bin/env bash #!/usr/bin/env bash
# Check if shell is using a default BSD or GNU prompt
if [[ ${PS1} != '\s-\v\$'* ]] && \
[[ ${PS1} != '%n@%m %1~ %#'* ]]; then
# User already has an opinionated PS1, just leave
return 0
fi
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
COMM_CACHE="${XDG_CACHE_HOME:-$HOME/Library/Caches}/app.comm" COMM_CACHE="${XDG_CACHE_HOME:-$HOME/Library/Caches}/app.comm"
else else
COMM_CACHE="${XDG_CACHE_HOME:-$HOME/.cache}/comm" COMM_CACHE="${XDG_CACHE_HOME:-$HOME/.cache}/comm"
fi fi
COMM_EMITTED_WARNING="$COMM_CACHE/powerline_warning" mkdir -p "$COMM_CACHE"
COMM_POWERLINE="$COMM_CACHE/enable-powerline"
# Only emit this the first time, as it's suprising to the user for the prompt # Only emit this the first time, as it's suprising to the user for the prompt
# to be replaced, but avoid emitting the warning on subsequent invocations # to be replaced, but avoid emitting the warning on subsequent invocations
if [[ ! -f "$COMM_EMITTED_WARNING" ]]; then if [[ ! -e "${COMM_POWERLINE}" ]]; then
echo "Default prompt found, attempting to enable powerline" >&2 read -r \
-p "Would you like to enable Powerline as the default bash prompt? [y/N] " \
response
case "$response" in
[yY][eE][sS]|[yY])
echo "1" > "${COMM_POWERLINE}"
;;
*)
touch "${COMM_POWERLINE}"
;;
esac
fi
# Create file to ensure it exists for next time this is run # If empty, user want's to use native prompt
mkdir -p "$COMM_CACHE" if [[ ! -s "${COMM_POWERLINE}" ]]; then
touch "$COMM_EMITTED_WARNING" return 0
fi fi
# Check if the powerline fonts are installed # Check if the powerline fonts are installed
# If the font is missing then many of the glyphs will render as ? # If the font is missing then many of the glyphs will render as ?
# Adapted from https://github.com/powerline/fonts/blob/master/install.sh # Adapted from https://github.com/powerline/fonts/blob/master/install.sh
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
# MacOS # MacOS
font_dir="$HOME/Library/Fonts" font_dir="$HOME/Library/Fonts"
else else
# Linux # Linux
font_dir="${XDG_DATA_HOME:-$HOME/.local/share}/fonts" font_dir="${XDG_DATA_HOME:-$HOME/.local/share}/fonts"
mkdir -p "$font_dir" mkdir -p "$font_dir"
fi fi
if [[ ! -f "$font_dir/Droid Sans Mono for Powerline.otf" ]]; then if [[ ! -f "$font_dir/Droid Sans Mono for Powerline.otf" ]]; then
if [[ ! -d "${powerline_fonts:-/doesnt-exist}" ]]; then if [[ ! -d "${powerline_fonts:-/doesnt-exist}" ]]; then
echo "Unable to determine powerline fonts location" >&2 echo "Unable to determine powerline fonts location" >&2
return 1 return 1
fi fi
echo "Installing powerline fonts" >&2 echo "Installing Powerline fonts" >&2
find "$powerline_fonts" \ find "$powerline_fonts" \
\( -name "*.[ot]tf" -or -name "*.pcf.gz" \) -type f -print0 \ \( -name "*.[ot]tf" -or -name "*.pcf.gz" \) -type f -print0 \
| xargs -0 -n1 -I % cp "%" "$font_dir/" | xargs -0 -n1 -I % cp "%" "$font_dir/"
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
if [[ "$TERM_PROGRAM" == "Apple_Terminal" ]]; then if [[ "$TERM_PROGRAM" == "Apple_Terminal" ]]; then
echo "For glyph support, please: echo "For glyph support, please:
Show All 17 Lines