Paths

Table of Contentst

[native] generate C++ spec for CommRustModule
ClosedPublic
Actions

Authored by kamil on Jul 28 2023, 4:47 PM.

Details

Reviewers

bartek
michal
tomek
varun

Commits

rCOMM7d6853161f4e: [native] generate C++ spec for CommRustModule

Summary

ENG-4232

Creating a separate module for Rust API. This is a part of CommCoreModule refactor.

Make codegen generate C++ for module.

Depends on D8655

Test Plan

run codegen-jsi

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 28 2023, 4:47 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 28 2023, 4:47 PM

kamil added a child revision: D8657: [native] add CommRustModule implementation.Jul 28 2023, 4:54 PM

Harbormaster failed remote builds in B21308: Diff 29184!Jul 28 2023, 5:10 PM

kamil published this revision for review.Jul 28 2023, 5:20 PM

bartek accepted this revision.Jul 31 2023, 9:46 AM

This revision is now accepted and ready to land.Jul 31 2023, 9:46 AM

rebase

Harbormaster failed remote builds in B21376: Diff 29288!Jul 31 2023, 4:56 PM

fix dependencies (I messed up while resolving conflicts)

Harbormaster completed remote builds in B21384: Diff 29296.Jul 31 2023, 6:44 PM

Closed by commit rCOMM7d6853161f4e: [native] generate C++ spec for CommRustModule. · Explain WhyAug 1 2023, 9:17 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM7d6853161f4e: [native] generate C++ spec for CommRustModule.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

CMakeLists.txt

1 line

codegen/

src/

index.js

4 lines

cpp/

CommonCpp/

_generated/

rustJSI-generated.cpp

rustJSI.h

ios/

Comm.xcodeproj/

project.pbxproj

6 lines

Diff 29411

View Options

native/android/app/CMakeLists.txt

View Options

native/codegen/src/index.js

View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/rustJSI.h

View Options

native/ios/Comm.xcodeproj/project.pbxproj

[native] generate C++ spec for CommRustModuleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29411

native/android/app/CMakeLists.txt

native/codegen/src/index.js

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

native/cpp/CommonCpp/_generated/rustJSI.h

native/ios/Comm.xcodeproj/project.pbxproj

[native] generate C++ spec for CommRustModule
ClosedPublic
Actions

Revision Contents
Changeset List