Paths

Table of Contentst

[identity] db method to get inbound keys for user
ClosedPublic
Actions

Authored by varun on Aug 8 2023, 7:40 AM.

Details

Reviewers

• jon
bartek

Commits

rCOMMa91792c497ce: [identity] db method to get inbound keys for user

Summary

Use username/wallet address to get the inbound keys for a user

Test Plan

tested in next diff

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Aug 8 2023, 7:40 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 8 2023, 7:40 AM

Harbormaster completed remote builds in B21589: Diff 29618.Aug 8 2023, 7:58 AM

varun requested review of this revision.Aug 8 2023, 7:58 AM

Just minor nits ;)

services/identity/src/database.rs
581–585 ↗	(On Diff #29618)	My preference, but up to you. Note that to format `let-else` you need to use `cargo +nightly fmt` - it is available in `rustfmt` v 1.6+
592 ↗	(On Diff #29618)	Minor optimization

This revision is now accepted and ready to land.Aug 8 2023, 8:29 AM

bartek added inline comments.Aug 8 2023, 8:33 AM

services/identity/src/database.rs
580 ↗	(On Diff #29618)	Maybe introduce some type aliases for these maps? It becomes difficult to keep up with what they represent.

I landed D8627, please rebase

This revision now requires changes to proceed.Aug 8 2023, 9:02 AM

varun added a child revision: D8765: [identity] more helpers for identity service.Aug 8 2023, 12:12 PM

rebase and address feedback

varun marked an inline comment as done.Aug 17 2023, 9:02 PM

Harbormaster completed remote builds in B21880: Diff 30058.Aug 17 2023, 9:20 PM

• jon accepted this revision.Aug 18 2023, 1:31 PM

• jon added inline comments.

services/identity/src/database.rs
737–739	After D8721, this could be just be

This revision is now accepted and ready to land.Aug 18 2023, 1:31 PM

varun added inline comments.Aug 30 2023, 11:05 AM

services/identity/src/database.rs
737–739	will address this in a new diff. i'd like to make the to_string method return a `String` instead of `&String` first

Closed by commit rCOMMa91792c497ce: [identity] db method to get inbound keys for user (authored by varun). · Explain WhyAug 30 2023, 11:38 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMa91792c497ce: [identity] db method to get inbound keys for user.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

2 lines

database.rs

131 lines

Diff 30058

View Options

services/identity/src/client_service.rs