Page MenuHomePhabricator
Differential D8960

[terraform][blob] Remove gRPC service
ClosedPublic
Actions

Authored by bartek on Aug 26 2023, 12:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 12:07 AM
Unknown Object (File)
Thu, Mar 6, 10:04 AM
Unknown Object (File)
Thu, Mar 6, 10:04 AM
Unknown Object (File)
Thu, Mar 6, 10:04 AM
Unknown Object (File)
Thu, Mar 6, 10:04 AM
Unknown Object (File)
Thu, Mar 6, 9:58 AM
Unknown Object (File)
Feb 11 2025, 4:44 PM
Unknown Object (File)
Jan 19 2025, 6:34 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
varun
kamil
• jon
Commits
rCOMMd627f5f2898f: [terraform][blob] Remove gRPC service
Summary

Part 2 of ENG-4297.
This diff removes blob gRPC from Terraform.

Depends on D8959

Test Plan
  • Staging:
    1. Build and push docker image from parent diff with latest tag
    2. Terraform apply this changes
    3. Verify everything's okay
  • Production:
    1. Build and push docker image from parent diff with version tag
    2. Terraform plan this changes
    3. Land this and apply changes
    4. Verify everything's okay, revert otherwise

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
terraform/
modules/
shared/
41 lines
remote/
60 lines

Diff 30351

View Options

services/terraform/modules/shared/dynamodb.tf

// @flow // @flow
import fs from 'fs'; import fs from 'fs';
import { policyTypes } from 'lib/facts/policies.js'; import { policyTypes } from 'lib/facts/policies.js';
import { messageTypes } from 'lib/types/message-types.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import { processMessagesInDBForSearch } from '../database/search-utils.js'; import { processMessagesInDBForSearch } from '../database/search-utils.js';
import { updateRolesAndPermissionsForAllThreads } from '../updaters/thread-permission-updaters.js'; import { updateRolesAndPermissionsForAllThreads } from '../updaters/thread-permission-updaters.js';
const migrations: $ReadOnlyMap<number, () => Promise<void>> = new Map([ const migrations: $ReadOnlyMap<number, () => Promise<void>> = new Map([
[ [
0, 0,
▲ Show 20 Lines • Show All 139 Lines • ▼ Show 20 Lines [
async () => { async () => {
await dbQuery( await dbQuery(
SQL` SQL`
ALTER TABLE uploads ALTER TABLE uploads
ADD COLUMN IF NOT EXISTS thread bigint(20) DEFAULT NULL, ADD COLUMN IF NOT EXISTS thread bigint(20) DEFAULT NULL,
ADD INDEX IF NOT EXISTS thread (thread); ADD INDEX IF NOT EXISTS thread (thread);
UPDATE uploads UPDATE uploads
SET thread = ( SET thread = (
SELECT thread FROM messages SELECT thread FROM messages
WHERE messages.id = uploads.container WHERE messages.id = uploads.container
); );
`, `,
{ multipleStatements: true }, { multipleStatements: true },
); );
}, },
], ],
[ [
16, 16,
async () => { async () => {
▲ Show 20 Lines • Show All 171 Lines • ▼ Show 20 Lines async () => {
ADD PRIMARY KEY (id), ADD PRIMARY KEY (id),
ADD UNIQUE KEY (name), ADD UNIQUE KEY (name),
ADD INDEX community_primary (community, \`primary\`); ADD INDEX community_primary (community, \`primary\`);
`, `,
{ multipleStatements: true }, { multipleStatements: true },
); );
}, },
], ],
[
32,
async () => {
await dbQuery(SQL`
UPDATE messages
SET target_message = JSON_VALUE(content, "$.sourceMessageID")
WHERE type = ${messageTypes.SIDEBAR_SOURCE};
`);
},
],
]); ]);
const newDatabaseVersion: number = Math.max(...migrations.keys()); const newDatabaseVersion: number = Math.max(...migrations.keys());
async function writeJSONToFile(data: any, filePath: string): Promise<void> { async function writeJSONToFile(data: any, filePath: string): Promise<void> {
console.warn(`updating ${filePath} to ${JSON.stringify(data)}`); console.warn(`updating ${filePath} to ${JSON.stringify(data)}`);
const fileHandle = await fs.promises.open(filePath, 'w'); const fileHandle = await fs.promises.open(filePath, 'w');
await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8'); await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8');
await fileHandle.close(); await fileHandle.close();
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines
View Options

services/terraform/remote/service_blob.tf

// @flow // @flow
import fs from 'fs'; import fs from 'fs';
import { policyTypes } from 'lib/facts/policies.js'; import { policyTypes } from 'lib/facts/policies.js';
import { messageTypes } from 'lib/types/message-types.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import { processMessagesInDBForSearch } from '../database/search-utils.js'; import { processMessagesInDBForSearch } from '../database/search-utils.js';
import { updateRolesAndPermissionsForAllThreads } from '../updaters/thread-permission-updaters.js'; import { updateRolesAndPermissionsForAllThreads } from '../updaters/thread-permission-updaters.js';
const migrations: $ReadOnlyMap<number, () => Promise<void>> = new Map([ const migrations: $ReadOnlyMap<number, () => Promise<void>> = new Map([
[ [
0, 0,
▲ Show 20 Lines • Show All 139 Lines • ▼ Show 20 Lines [
async () => { async () => {
await dbQuery( await dbQuery(
SQL` SQL`
ALTER TABLE uploads ALTER TABLE uploads
ADD COLUMN IF NOT EXISTS thread bigint(20) DEFAULT NULL, ADD COLUMN IF NOT EXISTS thread bigint(20) DEFAULT NULL,
ADD INDEX IF NOT EXISTS thread (thread); ADD INDEX IF NOT EXISTS thread (thread);
UPDATE uploads UPDATE uploads
SET thread = ( SET thread = (
SELECT thread FROM messages SELECT thread FROM messages
WHERE messages.id = uploads.container WHERE messages.id = uploads.container
); );
`, `,
{ multipleStatements: true }, { multipleStatements: true },
); );
}, },
], ],
[ [
16, 16,
async () => { async () => {
▲ Show 20 Lines • Show All 171 Lines • ▼ Show 20 Lines async () => {
ADD PRIMARY KEY (id), ADD PRIMARY KEY (id),
ADD UNIQUE KEY (name), ADD UNIQUE KEY (name),
ADD INDEX community_primary (community, \`primary\`); ADD INDEX community_primary (community, \`primary\`);
`, `,
{ multipleStatements: true }, { multipleStatements: true },
); );
}, },
], ],
[
32,
async () => {
await dbQuery(SQL`
UPDATE messages
SET target_message = JSON_VALUE(content, "$.sourceMessageID")
WHERE type = ${messageTypes.SIDEBAR_SOURCE};
`);
},
],
]); ]);
const newDatabaseVersion: number = Math.max(...migrations.keys()); const newDatabaseVersion: number = Math.max(...migrations.keys());
async function writeJSONToFile(data: any, filePath: string): Promise<void> { async function writeJSONToFile(data: any, filePath: string): Promise<void> {
console.warn(`updating ${filePath} to ${JSON.stringify(data)}`); console.warn(`updating ${filePath} to ${JSON.stringify(data)}`);
const fileHandle = await fs.promises.open(filePath, 'w'); const fileHandle = await fs.promises.open(filePath, 'w');
await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8'); await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8');
await fileHandle.close(); await fileHandle.close();
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines