[native] Convert `ComposedMessage` into a functional component
ClosedPublic
Actions

Authored by atul on Aug 31 2023, 3:51 PM.

Details

Reviewers

ginsu
rohan
tomek

Commits

rCOMM7d901c25c45e: [native] Convert `ComposedMessage` into a functional component

Summary

This allows us to memoize things in a more precise way and reduces some re-renders of child components.

Depends on D9051

Test Plan

ComposedMessage continues to behave as expected. A little more "gray" in the flamegraph (components aren't re-rendering), but nothing super impactful. Hopefully there will be more significant improvements in conjunction w/ subsequent diffs.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Aug 31 2023, 3:51 PM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 31 2023, 3:52 PM

atul retitled this revision from [native] Turn `ComposedMessage` into a functional component to [native] Convert `ComposedMessage` into a functional component.Aug 31 2023, 3:52 PM

atul published this revision for review.Aug 31 2023, 3:55 PM

Harbormaster completed remote builds in B22320: Diff 30661.Aug 31 2023, 4:08 PM

atul edited the summary of this revision. (Show Details)Aug 31 2023, 4:39 PM

atul added a parent revision: D9051: [native] Convert `ConnectedMessage` class component to functional `Message`.

atul added a child revision: D9053: [native] Memoize `PanGestureHandler` props in `SwipeableMessage`.

tomek accepted this revision.Sep 1 2023, 10:48 AM

tomek added inline comments.

native/chat/composed-message.react.js
151–158 ↗	(On Diff #30661)	This can be made a lot more efficient by using `inputState?.editInputMessage` as a dependency
217–219 ↗	(On Diff #30661)	You can use a shorthand
319–353 ↗	(On Diff #30661)	Not sure if this is really beneficial to memoize the return value in `React.memo` especially when so many dependencies are used.