[native] Memoize `PanGestureHandler` props in `SwipeableMessage`
ClosedPublic
Actions

Authored by atul on Aug 31 2023, 9:25 AM.

Details

Reviewers

ginsu
tomek
rohan

Commits

rCOMM46ac62ee6866: [native] Memoize `PanGestureHandler` props in `SwipeableMessage`

Summary

Based on flamegraph from profiler, it looks like A. creating SwipeSnakes and PanGestureHandler in SwipeableMessage is expensive B. because we're not memoizing things as carefully as we could be we're eating this cost multiple times.

In this diff I just memoize the PanGestureHandler props. In the subsequent diff I'll add some more memoization to this component specifically wrt the SwipeSnakes

Depends on D9052

Test Plan

"Before":

Will do another round of profiling after the subsequent diff to show improvement.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Aug 31 2023, 9:25 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 31 2023, 9:25 AM

atul published this revision for review.Aug 31 2023, 9:27 AM

atul edited the test plan for this revision. (Show Details)

atul edited the summary of this revision. (Show Details)Aug 31 2023, 9:40 AM

atul added a parent revision: D9052: [native] Convert `ComposedMessage` into a functional component.

Harbormaster completed remote builds in B22322: Diff 30663.Aug 31 2023, 9:44 AM

atul mentioned this in D9054: [native] Add more memoization to `SwipeableMessage`.Aug 31 2023, 9:56 AM

tomek accepted this revision.Sep 1 2023, 3:50 AM

tomek added inline comments.

native/chat/swipeable-message.react.js
242–243 ↗	(On Diff #30663)	It might be even better to define them outside the component

This revision is now accepted and ready to land.Sep 1 2023, 3:50 AM

atul added inline comments.Sep 5 2023, 11:29 AM

native/chat/swipeable-message.react.js
242–243 ↗	(On Diff #30663)	That's a good point. There might be an argument for defining this "close to where this is being used," but I'll go ahead and pull it out of component.