Page MenuHomePhabricator
Differential D9055

[native] Add some memoization to `InnerTextMessage` component
ClosedPublic
Actions

Authored by atul on Aug 31 2023, 11:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 7:44 PM
Unknown Object (File)
Sun, Nov 3, 7:44 PM
Unknown Object (File)
Sun, Nov 3, 7:44 PM
Unknown Object (File)
Sun, Nov 3, 7:41 PM
Unknown Object (File)
Sun, Nov 3, 7:23 PM
Unknown Object (File)
Mon, Oct 28, 1:45 PM
Unknown Object (File)
Oct 3 2024, 3:40 AM
Unknown Object (File)
Sep 29 2024, 4:58 AM
View All 75 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
rohan
Commits
rCOMM832b471c0618: [native] Add some memoization to `InnerTextMessage` component
Summary

Was able to reduce re-renders with some memoization.

Depends on D9054

Test Plan

Before:

6b03c7.png (1×2 px, 530 KB)

After:

762d99.png (1×344 px, 201 KB)

You can observe that we don't render anything nested within InnerTextMessage

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Aug 31 2023, 11:38 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 31 2023, 11:38 AM
atul published this revision for review.Aug 31 2023, 11:39 AM
atul edited the test plan for this revision. (Show Details)

As of this diff we've brought the "second render" of MessageList from ~100ms to ~40ms. The ThreadList optimizations should be 4-5x as impactful.

Harbormaster completed remote builds in B22325: Diff 30669.Aug 31 2023, 11:55 AM
tomek accepted this revision.Sep 1 2023, 5:41 AM
tomek added inline comments.
native/chat/inner-text-message.react.js
130–133 ↗(On Diff #30669)

Probably can be defined outside the component

This revision is now accepted and ready to land.Sep 1 2023, 5:41 AM
atul added inline comments.Sep 6 2023, 1:19 PM
native/chat/inner-text-message.react.js
130–133 ↗(On Diff #30669)

I think the cost of this is pretty low and would prefer to keep the styles "near" the JSX

atul updated this revision to Diff 30808.Sep 6 2023, 1:21 PM

rebase and land

This revision was landed with ongoing or failed builds.Sep 6 2023, 1:25 PM
Closed by commit rCOMM832b471c0618: [native] Add some memoization to `InnerTextMessage` component (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM832b471c0618: [native] Add some memoization to `InnerTextMessage` component.
Harbormaster completed remote builds in B22413: Diff 30808.Sep 6 2023, 1:40 PM

Revision Contents
Changeset List

PathSize
native/
chat/
137 lines

Diff 30809

View Options

native/chat/inner-text-message.react.js

Loading...