Differential D9113

[native] get notifications one time keys
ClosedPublic
Actions

Authored by varun on Sep 8 2023, 9:33 AM.

Tags

None

Referenced Files

	F4078974: D9113.id.diff
	Sat, Feb 15, 3:51 PM

	Unknown Object (File)
	Thu, Feb 13, 4:21 PM

	Unknown Object (File)
	Tue, Jan 21, 10:05 PM

	Unknown Object (File)
	Mon, Jan 20, 2:41 PM

	Unknown Object (File)
	Sat, Jan 18, 5:52 PM

	Unknown Object (File)
	Sat, Jan 18, 5:52 PM

	Unknown Object (File)
	Sat, Jan 18, 5:51 PM

	Unknown Object (File)
	Sat, Jan 18, 5:46 PM

View All 99 Files

Subscribers

Details

Reviewers

Commits

rCOMMf13fe4b8c615: [native] get notifications one time keys

Summary

we need to send the notif one time keys to the identity service

depends on D9085

Test Plan

console logged the getNotificationsOneTimeKeys output. got the following when trying to get 2 and 8 keys:

LOG  2 notif one time keys: {"curve25519":{"AAAAAQ":"yiyPOxAtEM9W3vLbCrGmgLSI1uN87Io22aIqAyV4GS8","AAAAAg":"Wh4RI2Ipnheh2bVVg27vYPh+665+SpM2H4IVNdBdjlg"}}
LOG  8 notif one time keys: {"curve25519":{"AAAAAw":"nx6pjgnIlwon6JJBDwMoHUTJuGQyWXlaKiNIUk38nF4","AAAABA":"5+TOgrUPJarYKGIyDLhFYxBTQUN5JLZIFQitNJoYDFY","AAAABQ":"NqY6yqiWvPco6OyVfQXOFHHsFnNToBojCBoUZaxobCQ","AAAACA":"GaVutqDQ5tnlwrOfb6EhSFSay/Al0l9mpeNBsLRiY3E","AAAABw":"JzZarwDf3zcN7Op+aNQWoeuEiGFU8BAyvykhOW1cUmQ","AAAACQ":"qAcrrP558HCYEeu3BZ+QTJY9BNfr5z96lfSjmDDtYlQ","AAAABg":"W4N7CBlV3UPdDdI32TpCYHTXL+EilPqH7RQMN4ijXzo","AAAACg":"T1vCUTrmmR/PpalbWZF1Zm1CLWsYaeLWJZnTx/vWf2s"}}

Diff Detail

Repository

Branch

native (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Sep 8 2023, 9:33 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 8 2023, 9:33 AM

Harbormaster completed remote builds in B22456: Diff 30873.Sep 8 2023, 9:51 AM

varun requested review of this revision.Sep 8 2023, 9:51 AM

varun added a child revision: D9114: [native] update action types and reducer for setting comm access token.Sep 8 2023, 12:54 PM

marcin accepted this revision.Sep 12 2023, 2:14 AM

This revision is now accepted and ready to land.Sep 12 2023, 2:14 AM

Closed by commit rCOMMf13fe4b8c615: [native] get notifications one time keys (authored by varun). · Explain WhySep 12 2023, 12:54 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMf13fe4b8c615: [native] get notifications one time keys.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.h

3 lines

CommCoreModule.cpp

26 lines

_generated/

commJSI-generated.cpp

schema/

CommCoreModuleSchema.js

3 lines

Diff 30873

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI.h

Loading...

native/schema/CommCoreModuleSchema.js

Loading...