Page MenuHomePhabricator

[tunnelbroker] Don't listen on localhost only
ClosedPublic

Authored by bartek on Sep 12 2023, 1:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 9:10 AM
Unknown Object (File)
Tue, Oct 22, 9:10 AM
Unknown Object (File)
Tue, Oct 22, 9:09 AM
Unknown Object (File)
Tue, Oct 22, 5:04 AM
Unknown Object (File)
Thu, Oct 17, 7:04 PM
Unknown Object (File)
Thu, Oct 17, 6:07 PM
Unknown Object (File)
Thu, Oct 17, 5:58 PM
Unknown Object (File)
Thu, Oct 17, 5:17 PM
Subscribers

Details

Summary

Tunnelbroker listened on 127.0.0.1 and ::1 only, which does't work for AWS. Changed to listen on all interfaces.

Depends on D9153

Test Plan

Connected to tunnelbroker from a different device over LAN.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Sep 12 2023, 2:03 PM
bartek added inline comments.
services/tunnelbroker/src/grpc/mod.rs
85 ↗(On Diff #30989)

Not related, but this log line is very confusing so fixed here

michal added inline comments.
services/tunnelbroker/src/websockets/mod.rs
21–22 ↗(On Diff #30989)

Is the origin part of the url used for testing or sth? Or could we add #[arg(env = "TUNNELBROKER_WEBSOCKET_PORT")] and always host on 0.0.0.0?

This revision is now accepted and ready to land.Sep 13 2023, 1:19 AM
services/tunnelbroker/src/websockets/mod.rs
21–22 ↗(On Diff #30989)

I don't know, I don't see any references.
I think Jon's idea was to be able to configure whole endpoints instead of just ports.

Anyway, I'm not planning to change it here