Paths

Table of Contentst

Differential D9155

[tunnelbroker] Don't listen on localhost only
ClosedPublic
Actions

Authored by bartek on Sep 12 2023, 1:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 20, 5:10 PM

	Unknown Object (File)
	Wed, Nov 20, 5:10 PM

	Unknown Object (File)
	Wed, Nov 20, 5:10 PM

	Unknown Object (File)
	Wed, Nov 20, 5:08 PM

	Unknown Object (File)
	Tue, Nov 5, 3:16 PM

	Unknown Object (File)
	Oct 22 2024, 9:10 AM

	Unknown Object (File)
	Oct 22 2024, 9:10 AM

	Unknown Object (File)
	Oct 22 2024, 9:09 AM

View All 90 Files

Subscribers

Details

Reviewers

kamil
michal
varun
• jon

Commits

rCOMM09141efe3bc4: [tunnelbroker] Don't listen on localhost only

Summary

Tunnelbroker listened on 127.0.0.1 and ::1 only, which does't work for AWS. Changed to listen on all interfaces.

Depends on D9153

Test Plan

Connected to tunnelbroker from a different device over LAN.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 12 2023, 1:45 PM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptSep 12 2023, 1:45 PM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

bartek added a child revision: D9156: [tunnelbroker] Make WebSocketSession generic.Sep 12 2023, 1:47 PM

bartek published this revision for review.Sep 12 2023, 2:03 PM

bartek added inline comments.

services/tunnelbroker/src/grpc/mod.rs
85 ↗	(On Diff #30989)	Not related, but this log line is very confusing so fixed here

Harbormaster completed remote builds in B22543: Diff 30989.Sep 12 2023, 2:05 PM

michal accepted this revision.Sep 13 2023, 1:19 AM

michal added inline comments.

services/tunnelbroker/src/websockets/mod.rs
21–22 ↗	(On Diff #30989)	Is the origin part of the url used for testing or sth? Or could we add `#[arg(env = "TUNNELBROKER_WEBSOCKET_PORT")]` and always host on `0.0.0.0`?

This revision is now accepted and ready to land.Sep 13 2023, 1:19 AM

bartek added inline comments.Sep 13 2023, 4:00 AM

services/tunnelbroker/src/websockets/mod.rs
21–22 ↗	(On Diff #30989)	I don't know, I don't see any references. I think Jon's idea was to be able to configure whole endpoints instead of just ports. Anyway, I'm not planning to change it here

kamil accepted this revision.Sep 13 2023, 9:22 AM

Closed by commit rCOMM09141efe3bc4: [tunnelbroker] Don't listen on localhost only (authored by bartek). · Explain WhySep 14 2023, 12:46 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM09141efe3bc4: [tunnelbroker] Don't listen on localhost only.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

grpc/

4 lines

websockets/

4 lines

Diff 31114

services/tunnelbroker/src/grpc/mod.rs

Loading...

services/tunnelbroker/src/websockets/mod.rs

Loading...