Page MenuHomePhabricator

[native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly
ClosedPublic

Authored by atul on Sep 14 2023, 1:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 18, 9:47 PM
Unknown Object (File)
Wed, Jul 17, 6:32 PM
Unknown Object (File)
Tue, Jul 9, 1:43 AM
Unknown Object (File)
Sun, Jul 7, 6:39 PM
Unknown Object (File)
Sun, Jul 7, 3:44 PM
Unknown Object (File)
Sat, Jul 6, 11:17 AM
Unknown Object (File)
Fri, Jul 5, 6:23 PM
Unknown Object (File)
Fri, Jul 5, 12:26 PM
Subscribers

Details

Summary

Instead of passing a function to create ChatThreadListSearch we can inline the component directly.

As part of this we also replace additionalProps w/ more precise innerSearchAutoFocus and innerSearchActive props.


Depends on D9207

Test Plan

Search experience continues to look and work as expected. Set logs in all expected callbacks to ensure that they fired as expected. Made sure that x-icon and "Cancel" button continue to look and behave as before.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.Sep 14 2023, 1:41 PM
tomek added inline comments.
native/chat/chat-thread-list.react.js
361 ↗(On Diff #31154)

We can use a shorthand

364 ↗(On Diff #31154)

We can also consider having an early return

This revision is now accepted and ready to land.Sep 18 2023, 3:58 AM
native/chat/chat-thread-list.react.js
361 ↗(On Diff #31154)

I'd prefer to be explicit here

364 ↗(On Diff #31154)

Will update to early return

address feedback: early-return