Page MenuHomePhabricator

[native] Add some basic memoization to `ChatThreadListSearch`
ClosedPublic

Authored by atul on Sep 14 2023, 2:16 PM.
Tags
None
Referenced Files
F1537168: D9210.id31156.diff
Sat, Apr 13, 3:57 PM
Unknown Object (File)
Fri, Apr 12, 7:45 PM
Unknown Object (File)
Fri, Apr 12, 7:44 PM
Unknown Object (File)
Fri, Apr 12, 6:20 PM
Unknown Object (File)
Fri, Apr 12, 7:53 AM
Unknown Object (File)
Thu, Apr 11, 9:18 AM
Unknown Object (File)
Wed, Apr 10, 1:15 AM
Unknown Object (File)
Tue, Apr 9, 9:34 PM
Subscribers

Details

Summary

Some straightforward memoization + removed some extraneous styles from both ChatThreadList and ChatThreadListSearch.


Depends on D9209

Test Plan

Search experience continues to look and work as expected. Set logs in all expected callbacks to ensure that they fired as expected. Made sure that x-icon and "Cancel" button continue to look and behave as before.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D9210_1 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.Sep 14 2023, 2:16 PM
This revision is now accepted and ready to land.Sep 18 2023, 6:01 AM
This revision was landed with ongoing or failed builds.Sep 18 2023, 1:46 PM
This revision was automatically updated to reflect the committed changes.