Page MenuHomePhabricator

[native] Consume `useThreadListSearch` in `ChatThreadList`
ClosedPublic

Authored by atul on Sep 14 2023, 3:51 PM.
Tags
None
Referenced Files
F2319425: D9212.id31230.diff
Mon, Jul 22, 7:39 PM
Unknown Object (File)
Wed, Jul 10, 10:28 AM
Unknown Object (File)
Tue, Jul 9, 3:14 PM
Unknown Object (File)
Tue, Jul 9, 3:14 PM
Unknown Object (File)
Tue, Jul 9, 3:14 PM
Unknown Object (File)
Tue, Jul 9, 3:14 PM
Unknown Object (File)
Tue, Jul 9, 3:11 PM
Unknown Object (File)
Sun, Jul 7, 8:44 PM
Subscribers

Details

Summary

Huge shoutout @jacek for giving us the gift of useThreadListSearch which we're able to just seamlessly drop into ChatThreadList. This further helps reduce the number of ChatThreadList re-renders.

We're getting closer, but there's still some more work to get to no re-renders of ChatThreadList when we navigate to MessageList from ThreadList...


Depends on D9211

Test Plan

Search experience continues to look and work as expected. Set logs in all expected callbacks to ensure that they fired as expected. Made sure that x-icon and "Cancel" button continue to look and behave as before.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Sep 14 2023, 4:09 PM

Nice to see the code a lot simpler!

native/chat/chat-thread-list-search.react.js
20

Not 100% though, cc @ginsu since he's brought it up recently

This revision is now accepted and ready to land.Sep 15 2023, 2:28 PM
This revision was landed with ongoing or failed builds.Sep 18 2023, 2:04 PM
This revision was automatically updated to reflect the committed changes.