[keyserver] Stop accepting http cookies
ClosedPublic
Actions

Authored by michal on Sep 25 2023, 7:37 AM.

Details

Reviewers

inka
kamil
ashoat
tomek
atul

Commits

rCOMMe0619045d12a: [keyserver] Stop accepting http cookies

Summary

ENG-4747
Depends on D9290

We are no longer sending http cookies from the web app, so we can stop accepting them. Note: that means that web clients will need to reload to run the cookie migration.

Test Plan

Check that the web app works and that the websocket connects

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Sep 25 2023, 7:37 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 25 2023, 7:37 AM

Harbormaster completed remote builds in B22835: Diff 31406.Sep 25 2023, 7:55 AM

michal requested review of this revision.Sep 25 2023, 7:55 AM

Note: that means that web clients will need to reload to run the cookie migration.

Will web clients just stop working? Or do we have some way to prompt them to refresh? This will be extra important for Electron clients, which typically are "long-running"

Yeah, the electron clients are bit bigger problem... There is a task for the reload prompt: ENG-961 but it wasn't prioritized. For this task I guess we could just leave this diff on phab for some time to let clients migrate? For the desktop app we could even make a "dummy" release to force a reload but not sure if that's worth it.