Page MenuHomePhabricator

[native] introduce tooltipButtonIcon to UserRelationshipTooltipModalParams
ClosedPublic

Authored by ginsu on Oct 5 2023, 3:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 26, 1:15 AM
Unknown Object (File)
Sat, Oct 26, 1:15 AM
Unknown Object (File)
Sat, Oct 26, 1:15 AM
Unknown Object (File)
Sat, Oct 26, 1:14 AM
Unknown Object (File)
Sat, Oct 26, 1:12 AM
Unknown Object (File)
Oct 11 2024, 3:45 PM
Unknown Object (File)
Sep 20 2024, 10:49 AM
Unknown Object (File)
Sep 20 2024, 10:47 AM
Subscribers

Details

Summary

Right now the UserRelationshipTooltipButton will only render a pencil icon for UserRelationshipTooltipButton. This works for RelationshipListItem since this is the icon that is used in this component; however, the user profile component uses a kebab (3 vertical dot) icon. To make sure that UserRelationshipTooltipButton works for both cases, I introduced tooltipButtonIcon as a nav param (can either have the value of pencil or menu)

This is step 4 in the list below
Outlined below are the steps I will take to update RelationshipListItemTooltipModal:

  1. Add the block action to relationship list item tooltip menu (RelationshipListItem won't need this option, but User profiles will. This is shown in the figma screenshot above)
  2. Rename RelationshipListItemTooltipModal to something more generic like UserRelationshipTooltipModal
  3. Make UserRelationshipTooltipButton into a functional component (We need to use the useColors hook in a subsequent diff)
  4. Introduce the tooltipButtonIcon as a param to RelationshipListItemTooltipModal (RelationshipListItem will use a pencil icon and user profiles will use a kebab menu icon)
  5. Introduce UserProfileMenuButton (This component will handle navigating to RelationshipListItemTooltipModal

Depends on D9380

Test Plan

Please see the screenshots below where UserRelationshipTooltipButton from RelationshipListItem uses the pencil icon and the UserRelationshipTooltipButton from the user profile uses the kebab menu icon

RelationshipListItem:

Screenshot 2023-10-05 at 6.34.03 PM.png (1×1 px, 696 KB)

User Profile:

Screenshot 2023-10-05 at 6.33.58 PM.png (1×1 px, 724 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu requested review of this revision.Oct 5 2023, 3:44 PM
This revision is now accepted and ready to land.Oct 5 2023, 4:31 PM
This revision was landed with ongoing or failed builds.Oct 5 2023, 6:39 PM
This revision was automatically updated to reflect the committed changes.