Page MenuHomePhabricator
Differential D9383

[native] introduce avatar constants
ClosedPublic
Actions

Authored by ginsu on Oct 5 2023, 6:07 PM.
Tags
None
Referenced Files
F3363079: D9383.id31708.diff
Sun, Nov 24, 11:56 PM
Unknown Object (File)
Fri, Nov 22, 2:29 PM
Unknown Object (File)
Fri, Nov 22, 2:21 PM
Unknown Object (File)
Fri, Nov 22, 8:49 AM
Unknown Object (File)
Sun, Nov 10, 3:29 AM
Unknown Object (File)
Oct 26 2024, 1:12 AM
Unknown Object (File)
Oct 20 2024, 3:41 PM
Unknown Object (File)
Oct 20 2024, 3:41 PM
View All 68 Files
Subscribers
ashoat
atul
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMM55b9a6cb5077: [native] introduce avatar constants
Summary

This diff address @atul's brittle code concerns in D9376

Depends on D9382

Test Plan

confirmed that there were no regressions with the sizing of avatars

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 5 2023, 6:07 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 5 2023, 6:07 PM
ginsu added reviewers: atul, inka.Oct 5 2023, 6:08 PM
ginsu edited the summary of this revision. (Show Details)
ginsu added a parent revision: D9382: [native] introduce UserProfileMenuButton.
ginsu mentioned this in D9376: [native] introduce UserProfileAvatarModal.
Harbormaster completed remote builds in B23028: Diff 31708.Oct 5 2023, 6:26 PM
ginsu requested review of this revision.Oct 5 2023, 6:26 PM
ginsu added a child revision: D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.Oct 6 2023, 3:43 AM
atul accepted this revision.Oct 6 2023, 7:58 AM

Thanks for addressing

This revision is now accepted and ready to land.Oct 6 2023, 7:58 AM
ginsu updated this revision to Diff 31831.Oct 9 2023, 1:43 PM

rebase before landing

Harbormaster completed remote builds in B23124: Diff 31831.Oct 9 2023, 2:01 PM
Closed by commit rCOMM55b9a6cb5077: [native] introduce avatar constants (authored by ginsu). · Explain WhyOct 9 2023, 2:18 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM55b9a6cb5077: [native] introduce avatar constants.

Revision Contents
Changeset List

PathSize
native/
avatars/
13 lines
44 lines
user-profile/
5 lines

Diff 31708

View Options

native/avatars/avatar-constants.js

Loading...
View Options

native/avatars/avatar.react.js

Loading...
View Options

native/user-profile/user-profile-avatar-modal.react.js

Loading...