Page MenuHomePhabricator

[web] Make worker and wasm urls relative
ClosedPublic

Authored by michal on Oct 6 2023, 7:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 12:28 AM
Unknown Object (File)
Fri, Nov 8, 12:28 AM
Unknown Object (File)
Fri, Nov 8, 12:28 AM
Unknown Object (File)
Fri, Nov 8, 12:08 AM
Unknown Object (File)
Thu, Nov 7, 8:05 PM
Unknown Object (File)
Sep 28 2024, 7:25 PM
Unknown Object (File)
Sep 10 2024, 6:33 AM
Unknown Object (File)
Sep 10 2024, 6:33 AM
Subscribers

Details

Summary

Part of ENG-5153

We would like to separate hosting web app on dev environment to localhost:3000/webapp/ and the keyserver logic to localhost:3000/keyserver/. This means that we want to start we need to replace absolute URL (that point to localhost:3000/) with relative ones.

Depends on D9396

Test Plan

Run yarn dev and yarn prod and check that both notif and database workers are downloaded with /comm/workers/ (this will be changed in the later diffs). Also make sure that on yarn prod opaque-ke and olm wasm files are also loaded through /comm/

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 6 2023, 8:07 AM
Harbormaster failed remote builds in B23055: Diff 31744!

I would change the test plan to make sure files are actually downloaded, not read from the cache, otherwise, it looks good

This revision is now accepted and ready to land.Oct 16 2023, 3:17 AM