[Tunnelbroker] update DDB schema to handle client message ID
ClosedPublic
Actions

Authored by kamil on Oct 12 2023, 4:07 AM.

Details

Reviewers

varun
michal
bartek
• jon

Commits

rCOMMe18a7c47bc8f: [Tunnelbroker] update DDB schema to handle client message ID

Summary

Issue and context why we need this: ENG-5171.

Test Plan

Send some messages and check if they're properly saved in DB:

Run test_messages_order to make sure:
messages can be properly retrieved and deleted
order is correct

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Oct 12 2023, 4:07 AM

kamil held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptOct 12 2023, 4:07 AM

Herald added subscribers: will, tomek, ashoat. · View Herald Transcript

kamil edited the test plan for this revision. (Show Details)Oct 12 2023, 4:08 AM

kamil added inline comments.Oct 12 2023, 4:10 AM

services/tunnelbroker/src/database/mod.rs
52 ↗	(On Diff #31957)	Returned `message_id` is needed later in the stack
services/tunnelbroker/src/grpc/mod.rs
42 ↗	(On Diff #31957)	the correct value here will be added in the next diff
services/tunnelbroker/src/websockets/session.rs
178 ↗	(On Diff #31957)	the correct value here will be added in the next diff

kamil added a child revision: D9460: [Tunnelbroker] generate client message ID for gRPC messages.Oct 12 2023, 4:21 AM

Harbormaster completed remote builds in B23205: Diff 31957.Oct 12 2023, 4:25 AM

kamil published this revision for review.Oct 12 2023, 8:13 AM

kamil added inline comments.

services/tunnelbroker/src/database/mod.rs
52 ↗	(On Diff #31957)	D9467
services/tunnelbroker/src/grpc/mod.rs
42 ↗	(On Diff #31957)	D9460
services/tunnelbroker/src/websockets/session.rs
178 ↗	(On Diff #31957)	D9462

bartek accepted this revision.Oct 13 2023, 3:21 AM

This revision is now accepted and ready to land.Oct 13 2023, 3:21 AM

It might be worth to introduce something like

struct MessageID {
  timestamp: DateTime<Utc>,
  client_message_id: String,
}

impl MessageID {
  pub fn new(client_message_id: String) -> Self {Self {timestmap: Utc::now(), client_message_id} }
}

And impls for converting to and from a string (timestamp#messageID)

kamil mentioned this in D9504: [Tunnelbroker] implement DDB message ID.Oct 16 2023, 5:56 AM

kamil added a parent revision: D9504: [Tunnelbroker] implement DDB message ID.Oct 16 2023, 5:57 AM

rebase

This revision was landed with ongoing or failed builds.Oct 16 2023, 6:48 AM

Closed by commit rCOMMe18a7c47bc8f: [Tunnelbroker] update DDB schema to handle client message ID (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil mentioned this in rCOMM8e93fd257a53: [Tunnelbroker] implement DDB message ID.

kamil added a commit: rCOMMe18a7c47bc8f: [Tunnelbroker] update DDB schema to handle client message ID.

Harbormaster completed remote builds in B23266: Diff 32041.Oct 16 2023, 7:04 AM