Issue: ENG-5149.
Protocol diagram: notion doc.
Response which client should receive after sending MessageToDeviceRequest.
Depends on D9462
Details
Details
Run tests
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- tb-work-2
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| shared/tunnelbroker_messages/src/messages/send_confirmation.rs | ||
|---|---|---|
| 1–2 | You can use this syntax to apply doc comments to the item they are in. So in this case this would be applied to the send_confirmation module. This is useful for module-level documentation. | |
| 6–14 | This should probably be moved to be above MessageSentStatus. enum MessageSentStatus {
/// Message with id was processed by Tunnelbroker
Success(String)
...
} | |
| 45 | Shouldn't this be SendConfirmation? | |
| shared/tunnelbroker_messages/src/messages/send_confirmation.rs | ||
|---|---|---|
| 33–36 | Nit: "confirmation" sounds like the message already succeeded but this also contains message send failures (not entirely happy with my name suggestion too tho) | |