[keyserver] change function names for getting clients to be more intuitive
ClosedPublic
Actions

Authored by varun on Oct 12 2023, 11:57 AM.

Details

Reviewers

bartek
michal

Commits

rCOMMae8f251a5b77: [keyserver] change function names for getting clients to be more intuitive

Summary

i also added back a module that we made dead code for some reason in https://phab.comm.dev/D8820 ... we definitely need this function so i think it was a mistake. i should've reviewed this more carefully before commandeering the diff.

Depends on D9472

Test Plan

cargo build, also called the function i added back from js and confirmed it still worked as expected

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Oct 12 2023, 11:57 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 12 2023, 11:57 AM

Harbormaster completed remote builds in B23220: Diff 31976.Oct 12 2023, 12:22 PM

varun requested review of this revision.Oct 12 2023, 12:22 PM

varun added a child revision: D9478: [shared] helper functions to get/set version unsupported status.Oct 12 2023, 10:30 PM

bartek accepted this revision.Oct 16 2023, 12:44 AM

This revision is now accepted and ready to land.Oct 16 2023, 12:44 AM

Closed by commit rCOMMae8f251a5b77: [keyserver] change function names for getting clients to be more intuitive (authored by varun). · Explain WhyOct 18 2023, 8:00 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMae8f251a5b77: [keyserver] change function names for getting clients to be more intuitive.

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

src/

identity_client/

add_reserved_usernames.rs

2 lines

get_inbound_keys_for_user.rs

7 lines

2 lines

mod.rs

5 lines

prekey.rs

10 lines

register_user.rs

2 lines

remove_reserved_usernames.rs

2 lines

upload_one_time_keys.rs

2 lines

Diff 31976

View Options

keyserver/addons/rust-node-addon/src/identity_client/add_reserved_usernames.rs

View Options

keyserver/addons/rust-node-addon/src/identity_client/get_inbound_keys_for_user.rs

View Options

keyserver/addons/rust-node-addon/src/identity_client/login.rs

View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

View Options

keyserver/addons/rust-node-addon/src/identity_client/prekey.rs

View Options

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs

View Options

keyserver/addons/rust-node-addon/src/identity_client/remove_reserved_usernames.rs

View Options

keyserver/addons/rust-node-addon/src/identity_client/upload_one_time_keys.rs

[keyserver] change function names for getting clients to be more intuitiveClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31976

keyserver/addons/rust-node-addon/src/identity_client/add_reserved_usernames.rs

keyserver/addons/rust-node-addon/src/identity_client/get_inbound_keys_for_user.rs

keyserver/addons/rust-node-addon/src/identity_client/login.rs

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

keyserver/addons/rust-node-addon/src/identity_client/prekey.rs

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs

keyserver/addons/rust-node-addon/src/identity_client/remove_reserved_usernames.rs

keyserver/addons/rust-node-addon/src/identity_client/upload_one_time_keys.rs

[keyserver] change function names for getting clients to be more intuitive
ClosedPublic
Actions

Revision Contents
Changeset List