Page MenuHomePhabricator
Differential D9529

[native] rename native themes-types to theme-utils
ClosedPublic
Actions

Authored by ginsu on Oct 18 2023, 9:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 1:28 AM
Unknown Object (File)
Wed, Apr 16, 1:13 AM
Unknown Object (File)
Tue, Apr 15, 8:57 PM
Unknown Object (File)
Tue, Apr 15, 8:16 PM
Unknown Object (File)
Tue, Apr 15, 1:40 PM
Unknown Object (File)
Sun, Apr 13, 3:52 PM
Unknown Object (File)
Wed, Apr 9, 9:48 AM
Unknown Object (File)
Wed, Apr 9, 7:37 AM
View All 74 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
rohan
Commits
rCOMM77d262dbe0cc: [native] rename native themes-types to theme-utils
Summary

Now that we lifted all the theme types into lib, the native file types would be better named as a utils file

Part of https://linear.app/comm/issue/ENG-4956/lift-any-necessary-shared-types-selectors-functions-for-storing-the

Depends on D9528

Test Plan

flow and confirmed that updating the app theme on native still works as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
profile/
2 lines
themes/
2 lines
themes/
types/
types/

Diff 32241

View Options

native/profile/appearance-preferences.react.js

// @flow // @flow
import classNames from 'classnames'; import classNames from 'classnames';
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import type { ChatMessageInfoItem } from 'lib/selectors/chat-selectors'; import type { ChatMessageInfoItem } from 'lib/selectors/chat-selectors';
import { useSidebarExistsOrCanBeCreated } from 'lib/shared/thread-utils'; import { useSidebarExistsOrCanBeCreated } from 'lib/shared/thread-utils';
import type { ThreadInfo } from 'lib/types/thread-types'; import type { ThreadInfo } from 'lib/types/thread-types';
import CommIcon from '../CommIcon.react.js';
import type { InputState } from '../input/input-state'; import type { InputState } from '../input/input-state';
import { import {
useOnClickThread, useOnClickThread,
useOnClickPendingSidebar, useOnClickPendingSidebar,
} from '../selectors/nav-selectors'; } from '../selectors/nav-selectors';
import SWMansionIcon from '../SWMansionIcon.react';
import MessageReplyButton from './message-reply-button.react'; import MessageReplyButton from './message-reply-button.react';
import css from './message-tooltip.css'; import css from './message-tooltip.css';
import type { import type {
ItemAndContainerPositionInfo, ItemAndContainerPositionInfo,
MessagePositionInfo, MessagePositionInfo,
OnMessagePositionWithContainerInfo, OnMessagePositionWithContainerInfo,
PositionInfo, PositionInfo,
} from './position-types'; } from './position-types';
▲ Show 20 Lines • Show All 152 Lines • ▼ Show 20 Linesfunction MessageTooltip(props: MessageTooltipProps): React.Node {
if (sidebarExistsOrCanBeCreated) { if (sidebarExistsOrCanBeCreated) {
sidebarButton = ( sidebarButton = (
<div <div
className={css.messageActionLinkIcon} className={css.messageActionLinkIcon}
onMouseEnter={showSidebarTooltip} onMouseEnter={showSidebarTooltip}
onMouseLeave={hideTooltip} onMouseLeave={hideTooltip}
onClick={onSidebarButtonClick} onClick={onSidebarButtonClick}
> >
<SWMansionIcon icon="message-circle-lines" size={18} /> <CommIcon icon="sidebar-filled" size={16} />
{activeTooltip === 'sidebar' ? tooltipMenu : null} {activeTooltip === 'sidebar' ? tooltipMenu : null}
</div> </div>
); );
} }
const { isViewer } = messageInfo.creator; const { isViewer } = messageInfo.creator;
const messageActionButtonsContainerClassName = classNames({ const messageActionButtonsContainerClassName = classNames({
[css.messageActionContainer]: true, [css.messageActionContainer]: true,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines
View Options

native/themes/theme-handler.react.js

// @flow // @flow
import classNames from 'classnames'; import classNames from 'classnames';
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import type { ChatMessageInfoItem } from 'lib/selectors/chat-selectors'; import type { ChatMessageInfoItem } from 'lib/selectors/chat-selectors';
import { useSidebarExistsOrCanBeCreated } from 'lib/shared/thread-utils'; import { useSidebarExistsOrCanBeCreated } from 'lib/shared/thread-utils';
import type { ThreadInfo } from 'lib/types/thread-types'; import type { ThreadInfo } from 'lib/types/thread-types';
import CommIcon from '../CommIcon.react.js';
import type { InputState } from '../input/input-state'; import type { InputState } from '../input/input-state';
import { import {
useOnClickThread, useOnClickThread,
useOnClickPendingSidebar, useOnClickPendingSidebar,
} from '../selectors/nav-selectors'; } from '../selectors/nav-selectors';
import SWMansionIcon from '../SWMansionIcon.react';
import MessageReplyButton from './message-reply-button.react'; import MessageReplyButton from './message-reply-button.react';
import css from './message-tooltip.css'; import css from './message-tooltip.css';
import type { import type {
ItemAndContainerPositionInfo, ItemAndContainerPositionInfo,
MessagePositionInfo, MessagePositionInfo,
OnMessagePositionWithContainerInfo, OnMessagePositionWithContainerInfo,
PositionInfo, PositionInfo,
} from './position-types'; } from './position-types';
▲ Show 20 Lines • Show All 152 Lines • ▼ Show 20 Linesfunction MessageTooltip(props: MessageTooltipProps): React.Node {
if (sidebarExistsOrCanBeCreated) { if (sidebarExistsOrCanBeCreated) {
sidebarButton = ( sidebarButton = (
<div <div
className={css.messageActionLinkIcon} className={css.messageActionLinkIcon}
onMouseEnter={showSidebarTooltip} onMouseEnter={showSidebarTooltip}
onMouseLeave={hideTooltip} onMouseLeave={hideTooltip}
onClick={onSidebarButtonClick} onClick={onSidebarButtonClick}
> >
<SWMansionIcon icon="message-circle-lines" size={18} /> <CommIcon icon="sidebar-filled" size={16} />
{activeTooltip === 'sidebar' ? tooltipMenu : null} {activeTooltip === 'sidebar' ? tooltipMenu : null}
</div> </div>
); );
} }
const { isViewer } = messageInfo.creator; const { isViewer } = messageInfo.creator;
const messageActionButtonsContainerClassName = classNames({ const messageActionButtonsContainerClassName = classNames({
[css.messageActionContainer]: true, [css.messageActionContainer]: true,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines
View Options

native/themes/theme-utils.js

// @flow // @flow
import classNames from 'classnames'; import classNames from 'classnames';
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import type { ChatMessageInfoItem } from 'lib/selectors/chat-selectors'; import type { ChatMessageInfoItem } from 'lib/selectors/chat-selectors';
import { useSidebarExistsOrCanBeCreated } from 'lib/shared/thread-utils'; import { useSidebarExistsOrCanBeCreated } from 'lib/shared/thread-utils';
import type { ThreadInfo } from 'lib/types/thread-types'; import type { ThreadInfo } from 'lib/types/thread-types';
import CommIcon from '../CommIcon.react.js';
import type { InputState } from '../input/input-state'; import type { InputState } from '../input/input-state';
import { import {
useOnClickThread, useOnClickThread,
useOnClickPendingSidebar, useOnClickPendingSidebar,
} from '../selectors/nav-selectors'; } from '../selectors/nav-selectors';
import SWMansionIcon from '../SWMansionIcon.react';
import MessageReplyButton from './message-reply-button.react'; import MessageReplyButton from './message-reply-button.react';
import css from './message-tooltip.css'; import css from './message-tooltip.css';
import type { import type {
ItemAndContainerPositionInfo, ItemAndContainerPositionInfo,
MessagePositionInfo, MessagePositionInfo,
OnMessagePositionWithContainerInfo, OnMessagePositionWithContainerInfo,
PositionInfo, PositionInfo,
} from './position-types'; } from './position-types';
▲ Show 20 Lines • Show All 152 Lines • ▼ Show 20 Linesfunction MessageTooltip(props: MessageTooltipProps): React.Node {
if (sidebarExistsOrCanBeCreated) { if (sidebarExistsOrCanBeCreated) {
sidebarButton = ( sidebarButton = (
<div <div
className={css.messageActionLinkIcon} className={css.messageActionLinkIcon}
onMouseEnter={showSidebarTooltip} onMouseEnter={showSidebarTooltip}
onMouseLeave={hideTooltip} onMouseLeave={hideTooltip}
onClick={onSidebarButtonClick} onClick={onSidebarButtonClick}
> >
<SWMansionIcon icon="message-circle-lines" size={18} /> <CommIcon icon="sidebar-filled" size={16} />
{activeTooltip === 'sidebar' ? tooltipMenu : null} {activeTooltip === 'sidebar' ? tooltipMenu : null}
</div> </div>
); );
} }
const { isViewer } = messageInfo.creator; const { isViewer } = messageInfo.creator;
const messageActionButtonsContainerClassName = classNames({ const messageActionButtonsContainerClassName = classNames({
[css.messageActionContainer]: true, [css.messageActionContainer]: true,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines
View Options

native/types/themes.js

// @flow // @flow
import classNames from 'classnames'; import classNames from 'classnames';
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import type { ChatMessageInfoItem } from 'lib/selectors/chat-selectors'; import type { ChatMessageInfoItem } from 'lib/selectors/chat-selectors';
import { useSidebarExistsOrCanBeCreated } from 'lib/shared/thread-utils'; import { useSidebarExistsOrCanBeCreated } from 'lib/shared/thread-utils';
import type { ThreadInfo } from 'lib/types/thread-types'; import type { ThreadInfo } from 'lib/types/thread-types';
import CommIcon from '../CommIcon.react.js';
import type { InputState } from '../input/input-state'; import type { InputState } from '../input/input-state';
import { import {
useOnClickThread, useOnClickThread,
useOnClickPendingSidebar, useOnClickPendingSidebar,
} from '../selectors/nav-selectors'; } from '../selectors/nav-selectors';
import SWMansionIcon from '../SWMansionIcon.react';
import MessageReplyButton from './message-reply-button.react'; import MessageReplyButton from './message-reply-button.react';
import css from './message-tooltip.css'; import css from './message-tooltip.css';
import type { import type {
ItemAndContainerPositionInfo, ItemAndContainerPositionInfo,
MessagePositionInfo, MessagePositionInfo,
OnMessagePositionWithContainerInfo, OnMessagePositionWithContainerInfo,
PositionInfo, PositionInfo,
} from './position-types'; } from './position-types';
▲ Show 20 Lines • Show All 152 Lines • ▼ Show 20 Linesfunction MessageTooltip(props: MessageTooltipProps): React.Node {
if (sidebarExistsOrCanBeCreated) { if (sidebarExistsOrCanBeCreated) {
sidebarButton = ( sidebarButton = (
<div <div
className={css.messageActionLinkIcon} className={css.messageActionLinkIcon}
onMouseEnter={showSidebarTooltip} onMouseEnter={showSidebarTooltip}
onMouseLeave={hideTooltip} onMouseLeave={hideTooltip}
onClick={onSidebarButtonClick} onClick={onSidebarButtonClick}
> >
<SWMansionIcon icon="message-circle-lines" size={18} /> <CommIcon icon="sidebar-filled" size={16} />
{activeTooltip === 'sidebar' ? tooltipMenu : null} {activeTooltip === 'sidebar' ? tooltipMenu : null}
</div> </div>
); );
} }
const { isViewer } = messageInfo.creator; const { isViewer } = messageInfo.creator;
const messageActionButtonsContainerClassName = classNames({ const messageActionButtonsContainerClassName = classNames({
[css.messageActionContainer]: true, [css.messageActionContainer]: true,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines