Page MenuHomePhabricator
Differential D9529

[native] rename native themes-types to theme-utils
ClosedPublic
Actions

Authored by ginsu on Oct 18 2023, 9:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 4, 8:50 AM
Unknown Object (File)
Feb 16 2025, 2:42 AM
Unknown Object (File)
Feb 16 2025, 2:42 AM
Unknown Object (File)
Feb 16 2025, 2:42 AM
Unknown Object (File)
Feb 16 2025, 2:41 AM
Unknown Object (File)
Feb 16 2025, 2:36 AM
Unknown Object (File)
Jan 13 2025, 5:49 PM
Unknown Object (File)
Dec 31 2024, 7:08 PM
View All 66 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
rohan
Commits
rCOMM77d262dbe0cc: [native] rename native themes-types to theme-utils
Summary

Now that we lifted all the theme types into lib, the native file types would be better named as a utils file

Part of https://linear.app/comm/issue/ENG-4956/lift-any-necessary-shared-types-selectors-functions-for-storing-the

Depends on D9528

Test Plan

flow and confirmed that updating the app theme on native still works as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
profile/
2 lines
themes/
2 lines
themes/
types/
types/

Diff 32241

View Options

native/profile/appearance-preferences.react.js

Show All 35 Linespub enum ReportType {
#[default] #[default]
ErrorReport = 0, ErrorReport = 0,
ThreadInconsistency = 1, ThreadInconsistency = 1,
EntryInconsistency = 2, EntryInconsistency = 2,
MediaMission = 3, MediaMission = 3,
UserInconsistency = 4, UserInconsistency = 4,
} }
impl ReportType {
pub fn is_error(&self) -> bool {
matches!(self, Self::ErrorReport)
}
pub fn is_media_mission(&self) -> bool {
matches!(self, Self::MediaMission)
}
pub fn is_inconsistency(&self) -> bool {
matches!(
self,
ReportType::ThreadInconsistency
| ReportType::EntryInconsistency
| ReportType::UserInconsistency
)
}
}
/// Report platform /// Report platform
#[derive(Clone, Debug, Serialize, Deserialize, Display)] #[derive(Clone, Debug, Serialize, Deserialize, Display)]
#[serde(rename_all = "lowercase")] #[serde(rename_all = "lowercase")]
pub enum ReportPlatform { pub enum ReportPlatform {
Android, Android,
IOS, IOS,
Web, Web,
Windows, Windows,
MacOS, MacOS,
} }
#[derive(Debug, Serialize, Deserialize)] #[derive(Debug, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
pub struct PlatformDetails { pub struct PlatformDetails {
pub platform: ReportPlatform, pub platform: ReportPlatform,
code_version: Option<u16>, pub code_version: Option<u16>,
state_version: Option<u16>, pub state_version: Option<u16>,
} }
/// Input report payload - this is the JSON we receive from clients /// Input report payload - this is the JSON we receive from clients
#[derive(Debug, Deserialize)] #[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
#[serde(remote = "Self")] // we delegate to our custom validation trait #[serde(remote = "Self")] // we delegate to our custom validation trait
pub struct ReportInput { pub struct ReportInput {
pub platform_details: PlatformDetails, pub platform_details: PlatformDetails,
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines
View Options

native/themes/theme-handler.react.js

Show All 35 Linespub enum ReportType {
#[default] #[default]
ErrorReport = 0, ErrorReport = 0,
ThreadInconsistency = 1, ThreadInconsistency = 1,
EntryInconsistency = 2, EntryInconsistency = 2,
MediaMission = 3, MediaMission = 3,
UserInconsistency = 4, UserInconsistency = 4,
} }
impl ReportType {
pub fn is_error(&self) -> bool {
matches!(self, Self::ErrorReport)
}
pub fn is_media_mission(&self) -> bool {
matches!(self, Self::MediaMission)
}
pub fn is_inconsistency(&self) -> bool {
matches!(
self,
ReportType::ThreadInconsistency
| ReportType::EntryInconsistency
| ReportType::UserInconsistency
)
}
}
/// Report platform /// Report platform
#[derive(Clone, Debug, Serialize, Deserialize, Display)] #[derive(Clone, Debug, Serialize, Deserialize, Display)]
#[serde(rename_all = "lowercase")] #[serde(rename_all = "lowercase")]
pub enum ReportPlatform { pub enum ReportPlatform {
Android, Android,
IOS, IOS,
Web, Web,
Windows, Windows,
MacOS, MacOS,
} }
#[derive(Debug, Serialize, Deserialize)] #[derive(Debug, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
pub struct PlatformDetails { pub struct PlatformDetails {
pub platform: ReportPlatform, pub platform: ReportPlatform,
code_version: Option<u16>, pub code_version: Option<u16>,
state_version: Option<u16>, pub state_version: Option<u16>,
} }
/// Input report payload - this is the JSON we receive from clients /// Input report payload - this is the JSON we receive from clients
#[derive(Debug, Deserialize)] #[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
#[serde(remote = "Self")] // we delegate to our custom validation trait #[serde(remote = "Self")] // we delegate to our custom validation trait
pub struct ReportInput { pub struct ReportInput {
pub platform_details: PlatformDetails, pub platform_details: PlatformDetails,
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines
View Options

native/themes/theme-utils.js

Show All 35 Linespub enum ReportType {
#[default] #[default]
ErrorReport = 0, ErrorReport = 0,
ThreadInconsistency = 1, ThreadInconsistency = 1,
EntryInconsistency = 2, EntryInconsistency = 2,
MediaMission = 3, MediaMission = 3,
UserInconsistency = 4, UserInconsistency = 4,
} }
impl ReportType {
pub fn is_error(&self) -> bool {
matches!(self, Self::ErrorReport)
}
pub fn is_media_mission(&self) -> bool {
matches!(self, Self::MediaMission)
}
pub fn is_inconsistency(&self) -> bool {
matches!(
self,
ReportType::ThreadInconsistency
| ReportType::EntryInconsistency
| ReportType::UserInconsistency
)
}
}
/// Report platform /// Report platform
#[derive(Clone, Debug, Serialize, Deserialize, Display)] #[derive(Clone, Debug, Serialize, Deserialize, Display)]
#[serde(rename_all = "lowercase")] #[serde(rename_all = "lowercase")]
pub enum ReportPlatform { pub enum ReportPlatform {
Android, Android,
IOS, IOS,
Web, Web,
Windows, Windows,
MacOS, MacOS,
} }
#[derive(Debug, Serialize, Deserialize)] #[derive(Debug, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
pub struct PlatformDetails { pub struct PlatformDetails {
pub platform: ReportPlatform, pub platform: ReportPlatform,
code_version: Option<u16>, pub code_version: Option<u16>,
state_version: Option<u16>, pub state_version: Option<u16>,
} }
/// Input report payload - this is the JSON we receive from clients /// Input report payload - this is the JSON we receive from clients
#[derive(Debug, Deserialize)] #[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
#[serde(remote = "Self")] // we delegate to our custom validation trait #[serde(remote = "Self")] // we delegate to our custom validation trait
pub struct ReportInput { pub struct ReportInput {
pub platform_details: PlatformDetails, pub platform_details: PlatformDetails,
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines
View Options

native/types/themes.js

Show All 35 Linespub enum ReportType {
#[default] #[default]
ErrorReport = 0, ErrorReport = 0,
ThreadInconsistency = 1, ThreadInconsistency = 1,
EntryInconsistency = 2, EntryInconsistency = 2,
MediaMission = 3, MediaMission = 3,
UserInconsistency = 4, UserInconsistency = 4,
} }
impl ReportType {
pub fn is_error(&self) -> bool {
matches!(self, Self::ErrorReport)
}
pub fn is_media_mission(&self) -> bool {
matches!(self, Self::MediaMission)
}
pub fn is_inconsistency(&self) -> bool {
matches!(
self,
ReportType::ThreadInconsistency
| ReportType::EntryInconsistency
| ReportType::UserInconsistency
)
}
}
/// Report platform /// Report platform
#[derive(Clone, Debug, Serialize, Deserialize, Display)] #[derive(Clone, Debug, Serialize, Deserialize, Display)]
#[serde(rename_all = "lowercase")] #[serde(rename_all = "lowercase")]
pub enum ReportPlatform { pub enum ReportPlatform {
Android, Android,
IOS, IOS,
Web, Web,
Windows, Windows,
MacOS, MacOS,
} }
#[derive(Debug, Serialize, Deserialize)] #[derive(Debug, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
pub struct PlatformDetails { pub struct PlatformDetails {
pub platform: ReportPlatform, pub platform: ReportPlatform,
code_version: Option<u16>, pub code_version: Option<u16>,
state_version: Option<u16>, pub state_version: Option<u16>,
} }
/// Input report payload - this is the JSON we receive from clients /// Input report payload - this is the JSON we receive from clients
#[derive(Debug, Deserialize)] #[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
#[serde(remote = "Self")] // we delegate to our custom validation trait #[serde(remote = "Self")] // we delegate to our custom validation trait
pub struct ReportInput { pub struct ReportInput {
pub platform_details: PlatformDetails, pub platform_details: PlatformDetails,
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines