Page MenuHomePhabricator

[lib/native] lift theme types from native into lib
ClosedPublic

Authored by ginsu on Oct 18 2023, 9:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 10:05 PM
Unknown Object (File)
Wed, Oct 30, 5:04 AM
Unknown Object (File)
Mon, Oct 28, 5:25 PM
Unknown Object (File)
Mon, Oct 28, 2:38 PM
Unknown Object (File)
Oct 4 2024, 1:46 AM
Unknown Object (File)
Oct 4 2024, 1:46 AM
Unknown Object (File)
Oct 4 2024, 1:46 AM
Unknown Object (File)
Oct 4 2024, 1:46 AM

Details

Summary

Now that we want to bring updateThemeInfo redux actions/state into web as well there are several things we should lift from native into lib so that we can share them across both platforms. This diff handles lifting the releveant theme types into lib

Part of https://linear.app/comm/issue/ENG-4956/lift-any-necessary-shared-types-selectors-functions-for-storing-the

Test Plan

flow and confirmed that updating the app theme on native still works as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/chat/settings/delete-thread.react.js
66 ↗(On Diff #32172)

We weren't using activeTheme anywhere in this component, so I just removed it

native/profile/edit-password.react.js
46 ↗(On Diff #32172)

We weren't using activeTheme anywhere in this component, so I just removed it

ginsu requested review of this revision.Oct 18 2023, 9:20 PM
This revision is now accepted and ready to land.Oct 19 2023, 11:17 AM