Page MenuHomePhabricator
Differential D9587

[native] introduce KeyserverSelectionListAddButton
ClosedPublic
Actions

Authored by ginsu on Oct 24 2023, 2:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 28, 3:55 AM
Unknown Object (File)
Sat, Sep 28, 3:55 AM
Unknown Object (File)
Sat, Sep 28, 3:55 AM
Unknown Object (File)
Sat, Sep 28, 3:55 AM
Unknown Object (File)
Sat, Sep 28, 3:54 AM
Unknown Object (File)
Sat, Sep 28, 3:49 AM
Unknown Object (File)
Aug 27 2024, 6:27 PM
Unknown Object (File)
Aug 27 2024, 6:23 PM
View All 62 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
inka
rohan
michal
Commits
rCOMMd979f2ce4b1e: [native] introduce KeyserverSelectionListAddButton
Summary

This diff introduces the KeyserverSelectionListAddButton and all the necessary navigation logic to navigate to the add keyserver input screen from the keyserver selection list screen

Linear task: https://linear.app/comm/issue/ENG-5408/introduce-keyserver-selection-list-header-right-button

Depends on D9586

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 24 2023, 2:47 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 24 2023, 2:47 PM
ginsu edited the summary of this revision. (Show Details)Oct 24 2023, 2:51 PM
ginsu added a parent revision: D9586: [native] introduce HeaderRightTextButton.
ginsu edited the test plan for this revision. (Show Details)Oct 24 2023, 2:57 PM
ginsu added reviewers: inka, rohan, michal.
ginsu attached a referenced file: F835908: Screen Recording 2023-10-24 at 5.56.27 PM.mov. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 24 2023, 2:59 PM
Harbormaster failed remote builds in B23463: Diff 32366!
ginsu requested review of this revision.Oct 24 2023, 3:00 PM

requesting review for now, will rebase/confirm that all builds succeed when CI is more stable

ginsu updated this revision to Diff 32374.Oct 24 2023, 4:41 PM

rebase

Harbormaster completed remote builds in B23469: Diff 32374.Oct 24 2023, 5:04 PM
ginsu added a child revision: D9590: [native] introduce Add keyserver screen UI.Oct 24 2023, 8:44 PM
rohan accepted this revision.Oct 26 2023, 8:34 AM
This revision is now accepted and ready to land.Oct 26 2023, 8:34 AM
ginsu updated this revision to Diff 32445.Oct 26 2023, 11:52 AM

rebase before landing

Harbormaster completed remote builds in B23523: Diff 32445.Oct 26 2023, 12:11 PM
Closed by commit rCOMMd979f2ce4b1e: [native] introduce KeyserverSelectionListAddButton (authored by ginsu). · Explain WhyOct 26 2023, 1:12 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMd979f2ce4b1e: [native] introduce KeyserverSelectionListAddButton.

Revision Contents
Changeset List

Diff 32374

View Options

native/navigation/route-names.js

Loading...
View Options

native/profile/add-keyserver.react.js

Loading...
View Options

native/profile/keyserver-selection-list-header-right-button.react.js

Loading...
View Options

native/profile/profile.react.js

Loading...