Page MenuHomePhabricator
Differential D9678

[identity] add RPC for logging in users with reserved wallet addresses
ClosedPublic
Actions

Authored by varun on Nov 2 2023, 5:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 7:17 PM
Unknown Object (File)
Sat, Mar 1, 11:12 AM
Unknown Object (File)
Sat, Mar 1, 9:36 AM
Unknown Object (File)
Sat, Mar 1, 9:36 AM
Unknown Object (File)
Sat, Mar 1, 9:36 AM
Unknown Object (File)
Sat, Mar 1, 9:36 AM
Unknown Object (File)
Sat, Mar 1, 9:35 AM
Unknown Object (File)
Feb 6 2025, 1:08 PM
View All Files
Subscribers
ashoat
tomek
will

Details

Reviewers
bartek
michal
• jon
Commits
rCOMMd958c50e9f0f: [identity] add RPC for logging in users with reserved wallet addresses
Summary

wallet users on ashoat's keyserver today will have to claim their address when they first auth with the identity service by calling this special RPC.

while implementing the new RPC i found some places in our code base that needed refactoring. if it's difficult to review i can split it out.

Test Plan

added my wallet address to the reserved usernames table. then successfully claimed it using the new RPC

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Nov 2 2023, 5:22 PM
Herald added a reviewer: • jon. · View Herald TranscriptNov 2 2023, 5:22 PM
Herald added subscribers: will, tomek, ashoat. · View Herald Transcript
varun added a child revision: D9679: [identity] check if wallet address is reserved in LoginWalletUser RPC.Nov 2 2023, 5:23 PM
Harbormaster completed remote builds in B23694: Diff 32650.Nov 2 2023, 5:45 PM
varun requested review of this revision.Nov 2 2023, 5:45 PM
varun updated this revision to Diff 32656.Nov 2 2023, 6:48 PM

don't generate new user ID for existing user

Harbormaster completed remote builds in B23698: Diff 32656.Nov 2 2023, 7:08 PM
michal accepted this revision.Nov 3 2023, 8:22 AM

LGTM but I haven't worked with identity service

services/identity/src/client_service.rs
591–608 ↗(On Diff #32656)

Could probably be extracted as it's used in 3 places.

This revision is now accepted and ready to land.Nov 3 2023, 8:22 AM
varun updated this revision to Diff 32685.Nov 3 2023, 11:47 AM

address feedback

varun added 1 blocking reviewer(s): bartek.Nov 3 2023, 11:50 AM

i think it's worth waiting until monday for bartek to review this

This revision now requires review to proceed.Nov 3 2023, 11:50 AM
Harbormaster failed remote builds in B23726: Diff 32685!Nov 3 2023, 11:51 AM
Harbormaster completed remote builds in B23726: Diff 32685.Nov 5 2023, 5:44 PM
bartek accepted this revision.Nov 6 2023, 1:14 AM
This revision is now accepted and ready to land.Nov 6 2023, 1:14 AM
Closed by commit rCOMMd958c50e9f0f: [identity] add RPC for logging in users with reserved wallet addresses (authored by varun). · Explain WhyNov 8 2023, 12:09 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMd958c50e9f0f: [identity] add RPC for logging in users with reserved wallet addresses.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
328 lines
14 lines
42 lines
1 line
shared/
protos/
15 lines

Diff 32973

View Options

services/identity/src/client_service.rs

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Linesconst light = Object.freeze({
subthreadsModalClose: designSystemColors.shadesBlack60, subthreadsModalClose: designSystemColors.shadesBlack60,
subthreadsModalBackground: designSystemColors.shadesWhite80, subthreadsModalBackground: designSystemColors.shadesWhite80,
subthreadsModalSearch: '#00000008', subthreadsModalSearch: '#00000008',
messageLabel: designSystemColors.shadesBlack100, messageLabel: designSystemColors.shadesBlack100,
modalSeparator: designSystemColors.shadesWhite60, modalSeparator: designSystemColors.shadesWhite60,
secondaryButtonBorder: designSystemColors.shadesWhite100, secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesBlack100, inviteLinkLinkColor: designSystemColors.shadesBlack100,
inviteLinkButtonBackground: designSystemColors.shadesWhite60, inviteLinkButtonBackground: designSystemColors.shadesWhite60,
emojiKeyboardKnob: designSystemColors.shadesWhite90,
emojiKeyboardCategoryIcon: designSystemColors.shadesBlack70,
emojiKeyboardContainerActive: designSystemColors.shadesWhite90,
ashoatUnsubmitted
Not Done
Inline Actions

Do we really need one-offs here? Why can't we find an existing color family that works with our designs?

We need to push the team (@tedchang in particular) to use existing families (and update them as necessary) instead of hacking around inconsistencies like this. When we take this sort of approach of picking colors on a per-screen basis, we fail to maintain stylistic / design consistency throughout the app

ashoat: Do we really need one-offs here? Why can't we find an existing color family that works with our…
ashoatUnsubmitted
Not Done
Inline Actions

Meant to tag @ted

ashoat: Meant to tag @ted
}); });
export type Colors = $Exact<typeof light>; export type Colors = $Exact<typeof light>;
const dark: Colors = Object.freeze({ const dark: Colors = Object.freeze({
blockQuoteBackground: '#A9A9A9', blockQuoteBackground: '#A9A9A9',
blockQuoteBorder: designSystemColors.shadesBlack60, blockQuoteBorder: designSystemColors.shadesBlack60,
codeBackground: designSystemColors.shadesBlack100, codeBackground: designSystemColors.shadesBlack100,
disabledButton: designSystemColors.shadesBlack80, disabledButton: designSystemColors.shadesBlack80,
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Linesconst dark: Colors = Object.freeze({
typeaheadTooltipBackground: '#1F1F1f', typeaheadTooltipBackground: '#1F1F1f',
typeaheadTooltipBorder: designSystemColors.shadesBlack80, typeaheadTooltipBorder: designSystemColors.shadesBlack80,
typeaheadTooltipText: 'white', typeaheadTooltipText: 'white',
messageLabel: designSystemColors.shadesWhite60, messageLabel: designSystemColors.shadesWhite60,
modalSeparator: designSystemColors.shadesBlack80, modalSeparator: designSystemColors.shadesBlack80,
secondaryButtonBorder: designSystemColors.shadesWhite100, secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesWhite80, inviteLinkLinkColor: designSystemColors.shadesWhite80,
inviteLinkButtonBackground: designSystemColors.shadesBlack80, inviteLinkButtonBackground: designSystemColors.shadesBlack80,
emojiKeyboardKnob: designSystemColors.shadesWhite100,
emojiKeyboardCategoryIcon: designSystemColors.shadesWhite70,
emojiKeyboardContainerActive: designSystemColors.shadesBlack60,
}); });
const colors = { light, dark }; const colors = { light, dark };
const colorsSelector: (state: AppState) => Colors = createSelector( const colorsSelector: (state: AppState) => Colors = createSelector(
(state: AppState) => state.globalThemeInfo.activeTheme, (state: AppState) => state.globalThemeInfo.activeTheme,
(theme: ?GlobalTheme) => { (theme: ?GlobalTheme) => {
const explicitTheme = theme ? theme : 'light'; const explicitTheme = theme ? theme : 'light';
return colors[explicitTheme]; return colors[explicitTheme];
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines
View Options

services/identity/src/database.rs

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Linesconst light = Object.freeze({
subthreadsModalClose: designSystemColors.shadesBlack60, subthreadsModalClose: designSystemColors.shadesBlack60,
subthreadsModalBackground: designSystemColors.shadesWhite80, subthreadsModalBackground: designSystemColors.shadesWhite80,
subthreadsModalSearch: '#00000008', subthreadsModalSearch: '#00000008',
messageLabel: designSystemColors.shadesBlack100, messageLabel: designSystemColors.shadesBlack100,
modalSeparator: designSystemColors.shadesWhite60, modalSeparator: designSystemColors.shadesWhite60,
secondaryButtonBorder: designSystemColors.shadesWhite100, secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesBlack100, inviteLinkLinkColor: designSystemColors.shadesBlack100,
inviteLinkButtonBackground: designSystemColors.shadesWhite60, inviteLinkButtonBackground: designSystemColors.shadesWhite60,
emojiKeyboardKnob: designSystemColors.shadesWhite90,
emojiKeyboardCategoryIcon: designSystemColors.shadesBlack70,
emojiKeyboardContainerActive: designSystemColors.shadesWhite90,
ashoatUnsubmitted
Not Done
Inline Actions

Do we really need one-offs here? Why can't we find an existing color family that works with our designs?

We need to push the team (@tedchang in particular) to use existing families (and update them as necessary) instead of hacking around inconsistencies like this. When we take this sort of approach of picking colors on a per-screen basis, we fail to maintain stylistic / design consistency throughout the app

ashoat: Do we really need one-offs here? Why can't we find an existing color family that works with our…
ashoatUnsubmitted
Not Done
Inline Actions

Meant to tag @ted

ashoat: Meant to tag @ted
}); });
export type Colors = $Exact<typeof light>; export type Colors = $Exact<typeof light>;
const dark: Colors = Object.freeze({ const dark: Colors = Object.freeze({
blockQuoteBackground: '#A9A9A9', blockQuoteBackground: '#A9A9A9',
blockQuoteBorder: designSystemColors.shadesBlack60, blockQuoteBorder: designSystemColors.shadesBlack60,
codeBackground: designSystemColors.shadesBlack100, codeBackground: designSystemColors.shadesBlack100,
disabledButton: designSystemColors.shadesBlack80, disabledButton: designSystemColors.shadesBlack80,
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Linesconst dark: Colors = Object.freeze({
typeaheadTooltipBackground: '#1F1F1f', typeaheadTooltipBackground: '#1F1F1f',
typeaheadTooltipBorder: designSystemColors.shadesBlack80, typeaheadTooltipBorder: designSystemColors.shadesBlack80,
typeaheadTooltipText: 'white', typeaheadTooltipText: 'white',
messageLabel: designSystemColors.shadesWhite60, messageLabel: designSystemColors.shadesWhite60,
modalSeparator: designSystemColors.shadesBlack80, modalSeparator: designSystemColors.shadesBlack80,
secondaryButtonBorder: designSystemColors.shadesWhite100, secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesWhite80, inviteLinkLinkColor: designSystemColors.shadesWhite80,
inviteLinkButtonBackground: designSystemColors.shadesBlack80, inviteLinkButtonBackground: designSystemColors.shadesBlack80,
emojiKeyboardKnob: designSystemColors.shadesWhite100,
emojiKeyboardCategoryIcon: designSystemColors.shadesWhite70,
emojiKeyboardContainerActive: designSystemColors.shadesBlack60,
}); });
const colors = { light, dark }; const colors = { light, dark };
const colorsSelector: (state: AppState) => Colors = createSelector( const colorsSelector: (state: AppState) => Colors = createSelector(
(state: AppState) => state.globalThemeInfo.activeTheme, (state: AppState) => state.globalThemeInfo.activeTheme,
(theme: ?GlobalTheme) => { (theme: ?GlobalTheme) => {
const explicitTheme = theme ? theme : 'light'; const explicitTheme = theme ? theme : 'light';
return colors[explicitTheme]; return colors[explicitTheme];
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines
View Options

services/identity/src/grpc_utils.rs

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Linesconst light = Object.freeze({
subthreadsModalClose: designSystemColors.shadesBlack60, subthreadsModalClose: designSystemColors.shadesBlack60,
subthreadsModalBackground: designSystemColors.shadesWhite80, subthreadsModalBackground: designSystemColors.shadesWhite80,
subthreadsModalSearch: '#00000008', subthreadsModalSearch: '#00000008',
messageLabel: designSystemColors.shadesBlack100, messageLabel: designSystemColors.shadesBlack100,
modalSeparator: designSystemColors.shadesWhite60, modalSeparator: designSystemColors.shadesWhite60,
secondaryButtonBorder: designSystemColors.shadesWhite100, secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesBlack100, inviteLinkLinkColor: designSystemColors.shadesBlack100,
inviteLinkButtonBackground: designSystemColors.shadesWhite60, inviteLinkButtonBackground: designSystemColors.shadesWhite60,
emojiKeyboardKnob: designSystemColors.shadesWhite90,
emojiKeyboardCategoryIcon: designSystemColors.shadesBlack70,
emojiKeyboardContainerActive: designSystemColors.shadesWhite90,
ashoatUnsubmitted
Not Done
Inline Actions

Do we really need one-offs here? Why can't we find an existing color family that works with our designs?

We need to push the team (@tedchang in particular) to use existing families (and update them as necessary) instead of hacking around inconsistencies like this. When we take this sort of approach of picking colors on a per-screen basis, we fail to maintain stylistic / design consistency throughout the app

ashoat: Do we really need one-offs here? Why can't we find an existing color family that works with our…
ashoatUnsubmitted
Not Done
Inline Actions

Meant to tag @ted

ashoat: Meant to tag @ted
}); });
export type Colors = $Exact<typeof light>; export type Colors = $Exact<typeof light>;
const dark: Colors = Object.freeze({ const dark: Colors = Object.freeze({
blockQuoteBackground: '#A9A9A9', blockQuoteBackground: '#A9A9A9',
blockQuoteBorder: designSystemColors.shadesBlack60, blockQuoteBorder: designSystemColors.shadesBlack60,
codeBackground: designSystemColors.shadesBlack100, codeBackground: designSystemColors.shadesBlack100,
disabledButton: designSystemColors.shadesBlack80, disabledButton: designSystemColors.shadesBlack80,
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Linesconst dark: Colors = Object.freeze({
typeaheadTooltipBackground: '#1F1F1f', typeaheadTooltipBackground: '#1F1F1f',
typeaheadTooltipBorder: designSystemColors.shadesBlack80, typeaheadTooltipBorder: designSystemColors.shadesBlack80,
typeaheadTooltipText: 'white', typeaheadTooltipText: 'white',
messageLabel: designSystemColors.shadesWhite60, messageLabel: designSystemColors.shadesWhite60,
modalSeparator: designSystemColors.shadesBlack80, modalSeparator: designSystemColors.shadesBlack80,
secondaryButtonBorder: designSystemColors.shadesWhite100, secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesWhite80, inviteLinkLinkColor: designSystemColors.shadesWhite80,
inviteLinkButtonBackground: designSystemColors.shadesBlack80, inviteLinkButtonBackground: designSystemColors.shadesBlack80,
emojiKeyboardKnob: designSystemColors.shadesWhite100,
emojiKeyboardCategoryIcon: designSystemColors.shadesWhite70,
emojiKeyboardContainerActive: designSystemColors.shadesBlack60,
}); });
const colors = { light, dark }; const colors = { light, dark };
const colorsSelector: (state: AppState) => Colors = createSelector( const colorsSelector: (state: AppState) => Colors = createSelector(
(state: AppState) => state.globalThemeInfo.activeTheme, (state: AppState) => state.globalThemeInfo.activeTheme,
(theme: ?GlobalTheme) => { (theme: ?GlobalTheme) => {
const explicitTheme = theme ? theme : 'light'; const explicitTheme = theme ? theme : 'light';
return colors[explicitTheme]; return colors[explicitTheme];
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines
View Options

services/identity/src/reserved_users.rs

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Linesconst light = Object.freeze({
subthreadsModalClose: designSystemColors.shadesBlack60, subthreadsModalClose: designSystemColors.shadesBlack60,
subthreadsModalBackground: designSystemColors.shadesWhite80, subthreadsModalBackground: designSystemColors.shadesWhite80,
subthreadsModalSearch: '#00000008', subthreadsModalSearch: '#00000008',
messageLabel: designSystemColors.shadesBlack100, messageLabel: designSystemColors.shadesBlack100,
modalSeparator: designSystemColors.shadesWhite60, modalSeparator: designSystemColors.shadesWhite60,
secondaryButtonBorder: designSystemColors.shadesWhite100, secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesBlack100, inviteLinkLinkColor: designSystemColors.shadesBlack100,
inviteLinkButtonBackground: designSystemColors.shadesWhite60, inviteLinkButtonBackground: designSystemColors.shadesWhite60,
emojiKeyboardKnob: designSystemColors.shadesWhite90,
emojiKeyboardCategoryIcon: designSystemColors.shadesBlack70,
emojiKeyboardContainerActive: designSystemColors.shadesWhite90,
ashoatUnsubmitted
Not Done
Inline Actions

Do we really need one-offs here? Why can't we find an existing color family that works with our designs?

We need to push the team (@tedchang in particular) to use existing families (and update them as necessary) instead of hacking around inconsistencies like this. When we take this sort of approach of picking colors on a per-screen basis, we fail to maintain stylistic / design consistency throughout the app

ashoat: Do we really need one-offs here? Why can't we find an existing color family that works with our…
ashoatUnsubmitted
Not Done
Inline Actions

Meant to tag @ted

ashoat: Meant to tag @ted
}); });
export type Colors = $Exact<typeof light>; export type Colors = $Exact<typeof light>;
const dark: Colors = Object.freeze({ const dark: Colors = Object.freeze({
blockQuoteBackground: '#A9A9A9', blockQuoteBackground: '#A9A9A9',
blockQuoteBorder: designSystemColors.shadesBlack60, blockQuoteBorder: designSystemColors.shadesBlack60,
codeBackground: designSystemColors.shadesBlack100, codeBackground: designSystemColors.shadesBlack100,
disabledButton: designSystemColors.shadesBlack80, disabledButton: designSystemColors.shadesBlack80,
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Linesconst dark: Colors = Object.freeze({
typeaheadTooltipBackground: '#1F1F1f', typeaheadTooltipBackground: '#1F1F1f',
typeaheadTooltipBorder: designSystemColors.shadesBlack80, typeaheadTooltipBorder: designSystemColors.shadesBlack80,
typeaheadTooltipText: 'white', typeaheadTooltipText: 'white',
messageLabel: designSystemColors.shadesWhite60, messageLabel: designSystemColors.shadesWhite60,
modalSeparator: designSystemColors.shadesBlack80, modalSeparator: designSystemColors.shadesBlack80,
secondaryButtonBorder: designSystemColors.shadesWhite100, secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesWhite80, inviteLinkLinkColor: designSystemColors.shadesWhite80,
inviteLinkButtonBackground: designSystemColors.shadesBlack80, inviteLinkButtonBackground: designSystemColors.shadesBlack80,
emojiKeyboardKnob: designSystemColors.shadesWhite100,
emojiKeyboardCategoryIcon: designSystemColors.shadesWhite70,
emojiKeyboardContainerActive: designSystemColors.shadesBlack60,
}); });
const colors = { light, dark }; const colors = { light, dark };
const colorsSelector: (state: AppState) => Colors = createSelector( const colorsSelector: (state: AppState) => Colors = createSelector(
(state: AppState) => state.globalThemeInfo.activeTheme, (state: AppState) => state.globalThemeInfo.activeTheme,
(theme: ?GlobalTheme) => { (theme: ?GlobalTheme) => {
const explicitTheme = theme ? theme : 'light'; const explicitTheme = theme ? theme : 'light';
return colors[explicitTheme]; return colors[explicitTheme];
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines
View Options

shared/protos/identity_client.proto

Loading...