Page MenuHomePhabricator
Differential D9678

[identity] add RPC for logging in users with reserved wallet addresses
ClosedPublic
Actions

Authored by varun on Nov 2 2023, 5:22 PM.
Tags
None
Referenced Files
F3399588: D9678.diff
Mon, Dec 2, 3:54 AM
Unknown Object (File)
Sat, Nov 30, 10:04 PM
Unknown Object (File)
Sun, Nov 24, 6:47 PM
Unknown Object (File)
Wed, Nov 13, 12:51 PM
Unknown Object (File)
Wed, Nov 13, 12:51 PM
Unknown Object (File)
Wed, Nov 13, 12:51 PM
Unknown Object (File)
Wed, Nov 13, 12:51 PM
Unknown Object (File)
Wed, Nov 13, 12:48 PM
View All 69 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
bartek
michal
• jon
Commits
rCOMMd958c50e9f0f: [identity] add RPC for logging in users with reserved wallet addresses
Summary

wallet users on ashoat's keyserver today will have to claim their address when they first auth with the identity service by calling this special RPC.

while implementing the new RPC i found some places in our code base that needed refactoring. if it's difficult to review i can split it out.

Test Plan

added my wallet address to the reserved usernames table. then successfully claimed it using the new RPC

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Nov 2 2023, 5:22 PM
Herald added a reviewer: • jon. · View Herald TranscriptNov 2 2023, 5:22 PM
Herald added subscribers: will, tomek, ashoat. · View Herald Transcript
varun added a child revision: D9679: [identity] check if wallet address is reserved in LoginWalletUser RPC.Nov 2 2023, 5:23 PM
Harbormaster completed remote builds in B23694: Diff 32650.Nov 2 2023, 5:45 PM
varun requested review of this revision.Nov 2 2023, 5:45 PM
varun updated this revision to Diff 32656.Nov 2 2023, 6:48 PM

don't generate new user ID for existing user

Harbormaster completed remote builds in B23698: Diff 32656.Nov 2 2023, 7:08 PM
michal accepted this revision.Nov 3 2023, 8:22 AM

LGTM but I haven't worked with identity service

services/identity/src/client_service.rs
591–608 ↗(On Diff #32656)

Could probably be extracted as it's used in 3 places.

This revision is now accepted and ready to land.Nov 3 2023, 8:22 AM
varun updated this revision to Diff 32685.Nov 3 2023, 11:47 AM

address feedback

varun added 1 blocking reviewer(s): bartek.Nov 3 2023, 11:50 AM

i think it's worth waiting until monday for bartek to review this

This revision now requires review to proceed.Nov 3 2023, 11:50 AM
Harbormaster failed remote builds in B23726: Diff 32685!Nov 3 2023, 11:51 AM
Harbormaster completed remote builds in B23726: Diff 32685.Nov 5 2023, 5:44 PM
bartek accepted this revision.Nov 6 2023, 1:14 AM
This revision is now accepted and ready to land.Nov 6 2023, 1:14 AM
Closed by commit rCOMMd958c50e9f0f: [identity] add RPC for logging in users with reserved wallet addresses (authored by varun). · Explain WhyNov 8 2023, 12:09 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMd958c50e9f0f: [identity] add RPC for logging in users with reserved wallet addresses.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
328 lines
14 lines
42 lines
1 line
shared/
protos/
15 lines

Diff 32973

View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/grpc_utils.rs

Loading...
View Options

services/identity/src/reserved_users.rs

Loading...
View Options

shared/protos/identity_client.proto

Loading...