[identity] check if wallet address is reserved in LoginWalletUser RPC
ClosedPublic
Actions

Authored by varun on Nov 2 2023, 5:23 PM.

Details

Reviewers

michal
bartek
• jon

Commits

rCOMM9805d7c756d8: [identity] check if wallet address is reserved in LoginWalletUser RPC

Summary

if the user already exists on the keyserver but is logging into the identity service for the first time, we should send back a specific error code instructing the client to get a signed message confirming their wallet address and user ID.

Depends on D9678

Test Plan

called the LoginWalletUser RPC with a reserved wallet address and received the expected error status code and message

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Nov 2 2023, 5:23 PM

Herald added a reviewer: • jon. · View Herald TranscriptNov 2 2023, 5:23 PM

Herald added subscribers: will, tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B23695: Diff 32651.Nov 2 2023, 5:41 PM

varun requested review of this revision.Nov 2 2023, 5:41 PM

michal accepted this revision.Nov 3 2023, 8:22 AM

This revision is now accepted and ready to land.Nov 3 2023, 8:22 AM

Closed by commit rCOMM9805d7c756d8: [identity] check if wallet address is reserved in LoginWalletUser RPC (authored by varun). · Explain WhyNov 8 2023, 12:09 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM9805d7c756d8: [identity] check if wallet address is reserved in LoginWalletUser RPC.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

20 lines

Diff 32651

View Options

services/identity/src/client_service.rs

[identity] check if wallet address is reserved in LoginWalletUser RPCClosedPublicActions