Page MenuHomePhabricator
Differential D9837

[web] introduce light mode to relationship lists
ClosedPublic
Actions

Authored by ginsu on Nov 13 2023, 7:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 1:17 PM
Unknown Object (File)
Tue, Oct 22, 1:17 PM
Unknown Object (File)
Tue, Oct 22, 1:17 PM
Unknown Object (File)
Tue, Oct 22, 9:18 AM
Unknown Object (File)
Tue, Oct 22, 5:05 AM
Unknown Object (File)
Wed, Oct 16, 4:46 AM
Unknown Object (File)
Oct 13 2024, 7:18 PM
Unknown Object (File)
Sep 18 2024, 7:40 PM
View All 65 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
rohan
Commits
rCOMM34a4474c1abe: [web] introduce light mode to relationship lists
Summary

This diff introduces the new color design system/light mode to the friend/block list modals

For additional context about this new color design system and the new naming convention here is the notion doc:
https://www.notion.so/commapp/New-Color-System-Proposal-ef80b4e4b9ec42949095056161223a42

Linear task: https://linear.app/comm/issue/ENG-4805/relationship-friendblock-list

Test Plan

Please see the screenshots below

light:

Screenshot 2023-11-13 at 10.07.19 AM.png (2×3 px, 718 KB)

dark:

Screenshot 2023-11-13 at 10.07.49 AM.png (2×3 px, 716 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Nov 13 2023, 7:06 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 13 2023, 7:06 AM
ginsu edited the summary of this revision. (Show Details)Nov 13 2023, 7:10 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, rohan.
ginsu edited the test plan for this revision. (Show Details)
ginsu attached a referenced file: F872349: Screenshot 2023-11-13 at 10.07.49 AM.png. (Show Details)
ginsu attached a referenced file: F872350: Screenshot 2023-11-13 at 10.07.19 AM.png. (Show Details)
ginsu added inline comments.Nov 13 2023, 7:14 AM
web/theme.css
138–142 ↗(On Diff #33121)

Confirmed that these were safe to remove

ginsu added a child revision: D9838: [web] introduce light mode to settings switcher.Nov 13 2023, 7:17 AM
Harbormaster completed remote builds in B24037: Diff 33121.Nov 13 2023, 7:25 AM
ginsu requested review of this revision.Nov 13 2023, 7:25 AM
atul accepted this revision.Nov 13 2023, 9:28 AM
This revision is now accepted and ready to land.Nov 13 2023, 9:28 AM
ginsu updated this revision to Diff 33135.Nov 13 2023, 11:22 AM

rebase before landing

This revision was landed with ongoing or failed builds.Nov 13 2023, 11:40 AM
Closed by commit rCOMM34a4474c1abe: [web] introduce light mode to relationship lists (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM34a4474c1abe: [web] introduce light mode to relationship lists.
Harbormaster completed remote builds in B24048: Diff 33135.Nov 13 2023, 12:06 PM

Revision Contents
Changeset List

PathSize
web/
components/
2 lines
12 lines
settings/
relationship/
4 lines
15 lines

Diff 33137

View Options

web/components/button.react.js

Loading...
View Options

web/components/search.css

Loading...
View Options

web/settings/relationship/user-list-row.css

Loading...
View Options

web/theme.css

Loading...