Paths

Table of Contentst

Differential D9838

[web] introduce light mode to settings switcher
ClosedPublic
Actions

Authored by ginsu on Nov 13 2023, 7:15 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 22, 1:17 PM

	Unknown Object (File)
	Tue, Oct 22, 1:17 PM

	Unknown Object (File)
	Tue, Oct 22, 1:17 PM

	Unknown Object (File)
	Tue, Oct 22, 9:18 AM

	Unknown Object (File)
	Tue, Oct 22, 5:05 AM

	Unknown Object (File)
	Mon, Oct 21, 12:49 PM

	Unknown Object (File)
	Sep 6 2024, 2:03 AM

	Unknown Object (File)
	Sep 6 2024, 2:03 AM

View All 63 Files

Subscribers

Details

Reviewers

atul
inka
rohan

Commits

rCOMM7359035856d7: [web] introduce light mode to settings switcher

Summary

This diff introduces the new color design system/light mode to the settings switcher component.

For additional context about this new color design system and the new naming convention here is the notion doc:
https://www.notion.so/commapp/New-Color-System-Proposal-ef80b4e4b9ec42949095056161223a42

Depends on D9837

Test Plan

Please see the screenshots below

light:

Screenshot 2023-11-13 at 10.17.02 AM.png (1×554 px, 62 KB)

dark:

Screenshot 2023-11-13 at 10.16.32 AM.png (1×746 px, 113 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Nov 13 2023, 7:15 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 13 2023, 7:15 AM

ginsu edited the summary of this revision. (Show Details)Nov 13 2023, 7:17 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka, rohan.

ginsu added a parent revision: D9837: [web] introduce light mode to relationship lists.

ginsu attached a referenced file: F872387: Screenshot 2023-11-13 at 10.16.32 AM.png. (Show Details)

ginsu attached a referenced file: F872386: Screenshot 2023-11-13 at 10.17.02 AM.png. (Show Details)

ginsu published this revision for review.Nov 13 2023, 7:31 AM

Harbormaster completed remote builds in B24038: Diff 33122.Nov 13 2023, 7:41 AM

atul accepted this revision.Nov 13 2023, 9:29 AM

atul added inline comments.

web/navigation-panels/settings-switcher.css
21–23 ↗	(On Diff #33122)	This is really for some inner SVG right?

This revision is now accepted and ready to land.Nov 13 2023, 9:29 AM

ginsu added inline comments.Nov 13 2023, 11:37 AM

web/navigation-panels/settings-switcher.css
21–23 ↗	(On Diff #33122)	Yes this class is used in the `NavigationPanel` component which is reused in the app bar which does have SVG. I will be further cleaning this up in https://linear.app/comm/issue/ENG-5021/top-bar

rebase before landing

This revision was landed with ongoing or failed builds.Nov 13 2023, 11:40 AM

Closed by commit rCOMM7359035856d7: [web] introduce light mode to settings switcher (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM7359035856d7: [web] introduce light mode to settings switcher.

Harbormaster completed remote builds in B24049: Diff 33136.Nov 13 2023, 11:59 AM

Revision Contents
Changeset List

Path

Size

web/

navigation-panels/

settings-switcher.css

12 lines

2 lines

Diff 33138

web/navigation-panels/settings-switcher.css

Loading...

web/style.css

Loading...