Page MenuHomePhabricator

[web] introduce keyserver pill component
ClosedPublic

Authored by ginsu on Nov 15 2023, 1:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 10:05 PM
Unknown Object (File)
Fri, Nov 8, 10:05 PM
Unknown Object (File)
Fri, Nov 8, 10:05 PM
Unknown Object (File)
Fri, Nov 8, 10:02 PM
Unknown Object (File)
Tue, Nov 5, 2:13 AM
Unknown Object (File)
Oct 16 2024, 1:41 AM
Unknown Object (File)
Sep 27 2024, 1:01 PM
Unknown Object (File)
Sep 11 2024, 2:44 PM
Subscribers

Details

Summary

This UI element will be repeated in several places in the keyserver selection list ui. Rather than copy + paste this logic a bunch of times, we should factor out this into a seperate + reusable component.

This is mainly a move diff; however, I did update the color variable names to follow our new color design system + made one change to the spacing between the two elements which I left a comment inline explaining

Test Plan

Confirmed that there were no regressions with the create community modal

Screenshot 2023-11-16 at 4.08.07 PM.png (1×3 px, 601 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

web/components/keyserver-pill.css
8 ↗(On Diff #33301)

Updated this from 6px => 4px based on the designs:

Screenshot 2023-11-15 at 4.30.02 PM.png (316×616 px, 140 KB)

ginsu requested review of this revision.Nov 15 2023, 4:12 PM

Can you share a screenshot of the UI that was changed? Not just the pill, but the pill in the context of where it's used

Can you share a screenshot of the UI that was changed? Not just the pill, but the pill in the context of where it's used

amended the test plan to show all the places this element is used in the web app

This revision is now accepted and ready to land.Nov 22 2023, 3:43 AM
This revision was automatically updated to reflect the committed changes.