Page MenuHomePhabricator

[web] introduce add keyserver button
ClosedPublic

Authored by ginsu on Nov 16 2023, 12:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 1:22 AM
Unknown Object (File)
Wed, Nov 13, 3:57 AM
Unknown Object (File)
Sun, Nov 10, 11:40 AM
Unknown Object (File)
Sun, Nov 10, 11:40 AM
Unknown Object (File)
Sun, Nov 10, 11:40 AM
Unknown Object (File)
Fri, Nov 8, 10:02 PM
Unknown Object (File)
Fri, Nov 8, 4:29 AM
Unknown Object (File)
Tue, Nov 5, 2:13 AM
Subscribers

Details

Summary

This diff introduces the add keyserver button element on to the keyserver selection list screen. When a user clicks on this element we should push the add keyserver modal

Here is a screenshot of the figma for context:

Screenshot 2023-11-14 at 5.21.32 PM.png (1×1 px, 170 KB)

Linear task: https://linear.app/comm/issue/ENG-4724/create-add-keyserver-button-element

Depends on D9916

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 16 2023, 12:46 PM
Harbormaster failed remote builds in B24224: Diff 33360!

Code looks fine! I'm assuming the color additions to theme.css were all agreed on before hand

web/settings/keyserver-selection-list.react.js
35–37 ↗(On Diff #33360)
This revision is now accepted and ready to land.Nov 17 2023, 7:55 AM

address comments + rebase before landing

This revision was automatically updated to reflect the committed changes.