Paths

Table of Contentst

Differential D9892

[web] introduce keyserver selection list
ClosedPublic
Actions

Authored by ginsu on Nov 14 2023, 8:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 8, 10:05 PM

	Unknown Object (File)
	Fri, Nov 8, 10:05 PM

	Unknown Object (File)
	Fri, Nov 8, 10:05 PM

	Unknown Object (File)
	Fri, Nov 8, 10:02 PM

	Unknown Object (File)
	Fri, Nov 8, 7:06 AM

	Unknown Object (File)
	Fri, Nov 8, 4:46 AM

	Unknown Object (File)
	Tue, Nov 5, 2:13 AM

	Unknown Object (File)
	Wed, Oct 23, 3:04 PM

View All 96 Files

Subscribers

Details

Reviewers

inka
rohan
michal

Commits

rCOMM8927c3f5b07a: [web] introduce keyserver selection list

Summary

This diff introduces the barebones KeyserverSelectionList. Subsequent diffs will handle introducing the add and remove keyserver user experiences

Linear task: https://linear.app/comm/issue/ENG-5494/implement-remaining-elements-of-the-keyserver-selection-screen-ui

Depends on D9891

Test Plan

Please see the screenshot below

Screenshot 2023-11-14 at 11.17.22 PM.png (2×3 px, 804 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Nov 14 2023, 8:16 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 14 2023, 8:16 PM

ginsu edited the summary of this revision. (Show Details)Nov 14 2023, 8:21 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: inka, rohan, michal.

ginsu added a parent revision: D9891: [web] introduce keyserver selection list item.

ginsu edited the summary of this revision. (Show Details)

ginsu attached a referenced file: F877637: Screenshot 2023-11-14 at 11.17.22 PM.png. (Show Details)

ginsu added inline comments.Nov 14 2023, 8:24 PM

web/settings/keyserver-selection-list.react.js
33 ↗	(On Diff #33250)	Using h4 here to keep consistent with our other settings ui: https://github.com/CommE2E/comm/blob/master/web/settings/account-settings.react.js#L159 https://github.com/CommE2E/comm/blob/master/web/settings/danger-zone.react.js#L21

Harbormaster completed remote builds in B24139: Diff 33250.Nov 14 2023, 8:40 PM

ginsu requested review of this revision.Nov 14 2023, 8:40 PM

inka added inline comments.Nov 16 2023, 8:41 AM

web/settings/keyserver-selection-list.react.js
30 ↗	(On Diff #33250)	I don't think this memo is necessary, what is expansive here if `selectedKeyservers` are memoized anyway?

ginsu added a child revision: D9916: [web] introduce add keyserver modal.Nov 16 2023, 10:03 AM

ginsu added inline comments.Nov 16 2023, 12:20 PM

web/settings/keyserver-selection-list.react.js
30 ↗	(On Diff #33250)	In D9918 we will introduce an svg element here which is not the cheapest thing to rerender

inka accepted this revision.Nov 17 2023, 4:46 AM

inka added inline comments.

web/settings/keyserver-selection-list.react.js
30 ↗	(On Diff #33250)	Okay, thank you for explaining!

This revision is now accepted and ready to land.Nov 17 2023, 4:46 AM

rebase before landing

Harbormaster failed remote builds in B24413: Diff 33612!Nov 26 2023, 6:12 PM

Harbormaster completed remote builds in B24413: Diff 33612.Nov 26 2023, 6:40 PM

Closed by commit rCOMM8927c3f5b07a: [web] introduce keyserver selection list (authored by ginsu). · Explain WhyNov 26 2023, 8:18 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM8927c3f5b07a: [web] introduce keyserver selection list.

Revision Contents
Changeset List

Path

Size

web/

3 lines

settings/

keyserver-selection-list.css

12 lines

keyserver-selection-list.react.js

43 lines

Diff 33616

web/app.react.js

Loading...

web/settings/keyserver-selection-list.css

Loading...

web/settings/keyserver-selection-list.react.js

Loading...