Page MenuHomePhabricator

[web] introduce keyserver selection list
ClosedPublic

Authored by ginsu on Nov 14 2023, 8:16 PM.
Tags
None
Referenced Files
F3349994: D9892.diff
Fri, Nov 22, 8:09 PM
Unknown Object (File)
Sun, Nov 10, 4:27 PM
Unknown Object (File)
Fri, Nov 8, 10:05 PM
Unknown Object (File)
Fri, Nov 8, 10:05 PM
Unknown Object (File)
Fri, Nov 8, 10:05 PM
Unknown Object (File)
Fri, Nov 8, 10:02 PM
Unknown Object (File)
Fri, Nov 8, 7:06 AM
Unknown Object (File)
Fri, Nov 8, 4:46 AM
Subscribers

Details

Summary

This diff introduces the barebones KeyserverSelectionList. Subsequent diffs will handle introducing the add and remove keyserver user experiences

Linear task: https://linear.app/comm/issue/ENG-5494/implement-remaining-elements-of-the-keyserver-selection-screen-ui

Depends on D9891

Test Plan

Please see the screenshot below

Screenshot 2023-11-14 at 11.17.22 PM.png (2×3 px, 804 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: inka, rohan, michal.
ginsu edited the summary of this revision. (Show Details)
ginsu requested review of this revision.Nov 14 2023, 8:40 PM
web/settings/keyserver-selection-list.react.js
30

I don't think this memo is necessary, what is expansive here if selectedKeyservers are memoized anyway?

web/settings/keyserver-selection-list.react.js
30

In D9918 we will introduce an svg element here which is not the cheapest thing to rerender

inka added inline comments.
web/settings/keyserver-selection-list.react.js
30

Okay, thank you for explaining!

This revision is now accepted and ready to land.Nov 17 2023, 4:46 AM
This revision was automatically updated to reflect the committed changes.