[keyserver/lib] Introduce a specialRoles enum and special_role column in MariaDB
ClosedPublic
Actions

Authored by rohan on Nov 23 2023, 8:18 AM.

Details

Reviewers

atul
ginsu
tomek

Commits

rCOMM15c203dd660f: [keyserver/lib] Introduce a specialRoles enum and special_role column in MariaDB

Summary

We introduce the specialRoles enum that maps a DEFAULT_ROLE to a specfic number we store in MariaDB. With this, we can run a migration that:

Adds a special_role column to roles
Update each row in roles to populate the special_role field if it is the defualt role

Addresses ENG-5831 and ENG-5832

Test Plan

Ran the migration and confirmed it succeeded. Also checked my roles table to make sure the correct roles were updated

Screenshot 2023-11-23 at 11.17.35 AM.png (1×1 px, 663 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Nov 23 2023, 8:18 AM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 23 2023, 8:18 AM

rohan retitled this revision from [keyserver/lib] Introduce a specialRoles enum and special_role column in MariaDB" to [keyserver/lib] Introduce a specialRoles enum and special_role column in MariaDB.Nov 23 2023, 8:18 AM

rohan edited the test plan for this revision. (Show Details)

Remove blank line

Harbormaster completed remote builds in B24378: Diff 33571.Nov 23 2023, 8:39 AM

Harbormaster completed remote builds in B24379: Diff 33572.Nov 23 2023, 8:43 AM

rohan requested review of this revision.Nov 23 2023, 8:43 AM

rohan added a child revision: D9974: [keyserver/lib] Populate special_role field when initial roles are created.Nov 24 2023, 9:47 AM

tomek accepted this revision.Nov 27 2023, 12:44 AM

This revision is now accepted and ready to land.Nov 27 2023, 12:44 AM

Change index on roles from thread to thread_special_role. Re-requesting review since I'd like another pass on this.

Tested this by running SHOW INDEX FROM roles both before and after and confirmed the index was created.

Did some research prior to this and looks like MySQL doesn't support a ALTER INDEX statement, so dropping the index & recreating it seems like the best path forward.

rohan requested review of this revision.Nov 27 2023, 8:18 AM

tomek accepted this revision.Nov 27 2023, 8:25 AM

This revision is now accepted and ready to land.Nov 27 2023, 8:25 AM

rohan mentioned this in D9977: [keyserver] Update usage of threads.default_role in thread-updaters.js.Nov 27 2023, 9:47 AM

This revision was landed with ongoing or failed builds.Nov 27 2023, 10:36 AM

Closed by commit rCOMM15c203dd660f: [keyserver/lib] Introduce a specialRoles enum and special_role column in MariaDB (authored by rohan). · Explain Why

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM15c203dd660f: [keyserver/lib] Introduce a specialRoles enum and special_role column in MariaDB.

Harbormaster completed remote builds in B24528: Diff 33746.Nov 27 2023, 11:05 AM