Page MenuHomePhabricator
Differential D3161

[services] Backup - Add DB test for Backup
ClosedPublic
Actions

Authored by • karol on Feb 10 2022, 6:29 AM.
Tags
None
Referenced Files
F3354205: D3161.diff
Sat, Nov 23, 12:22 PM
Unknown Object (File)
Sat, Nov 9, 4:38 AM
Unknown Object (File)
Sat, Nov 9, 2:49 AM
Unknown Object (File)
Wed, Nov 6, 11:35 AM
Unknown Object (File)
Tue, Nov 5, 6:42 PM
Unknown Object (File)
Mon, Oct 28, 1:07 PM
Unknown Object (File)
Oct 14 2024, 3:05 PM
Unknown Object (File)
Oct 13 2024, 6:27 PM
View All Files
Subscribers
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
• max
varun
ashoat
• jim
Commits
rCOMMd97608371e00: [services] Backup - Add DB test for Backup
Summary

Adding test for database operations on BackupItems

Depends on D3160

Test Plan
cd services
yarn test-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Feb 10 2022, 6:29 AM
Herald added subscribers: atul, • adrian, tomek, ashoat. · View Herald TranscriptFeb 10 2022, 6:29 AM
• karol edited the summary of this revision. (Show Details)Feb 10 2022, 6:38 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max, varun.
• karol added a parent revision: D3160: [services] Backup - Add DB operations for Backup.
Harbormaster completed remote builds in B6711: Diff 9521.Feb 10 2022, 6:46 AM
• karol requested review of this revision.Feb 10 2022, 6:46 AM
• karol added a comment.Feb 10 2022, 7:10 AM
tomek accepted this revision.Feb 11 2022, 2:24 AM
This revision is now accepted and ready to land.Feb 11 2022, 2:24 AM
Herald added a reviewer: ashoat. · View Herald TranscriptFeb 11 2022, 2:24 AM
Herald added a subscriber: • benschac. · View Herald Transcript
This revision now requires review to proceed.Feb 11 2022, 2:24 AM
• karol added a child revision: D3175: [services] Backup - Add DB operations for Logs.Feb 11 2022, 3:44 AM
ashoat accepted this revision.Feb 13 2022, 8:09 PM
ashoat added a reviewer: • jim.
This revision is now accepted and ready to land.Feb 13 2022, 8:09 PM
• karol updated this revision to Diff 9657.Feb 15 2022, 4:35 AM

update

Harbormaster failed remote builds in B6818: Diff 9657!Feb 15 2022, 4:46 AM
tomek requested changes to this revision.Feb 16 2022, 3:06 AM

Not sure if you noticed, but CI reports that this code has some compilation issues. It doesn't look like changes from this diff are causing that, so maybe a rebase could fix the issue

This revision now requires changes to proceed.Feb 16 2022, 3:06 AM
• karol requested review of this revision.Feb 16 2022, 6:26 AM

Thanks for noticing. It's not about rebasing, it's an error in the code.

I'm going to push the fix.

It also failed in D3160 and it's a bug there, not here.

tomek accepted this revision.Feb 16 2022, 6:30 AM

Ok, so I'll accept here and request changes there

This revision is now accepted and ready to land.Feb 16 2022, 6:30 AM
• karol updated this revision to Diff 9729.Feb 16 2022, 7:13 AM

what's up CI?

Harbormaster completed remote builds in B6881: Diff 9729.Feb 16 2022, 7:18 AM
Closed by commit rCOMMd97608371e00: [services] Backup - Add DB test for Backup (authored by • karol). · Explain WhyMar 4 2022, 4:04 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMd97608371e00: [services] Backup - Add DB test for Backup.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
4 lines
test/
58 lines

Diff 10062

View Options

services/backup/docker-server/contents/server/CMakeLists.txt

Loading...
View Options

services/backup/docker-server/contents/server/test/DatabaseManagerTest.cpp

Loading...