[web] Render AppSwitcher or SettingsSwitcher depending on the navigation
ClosedPublic
Actions

Authored by tomek on Mar 4 2022, 9:26 AM.

Details

Reviewers

• benschac
atul
• jacek

Commits

rCOMMc99c887f1b8b: [web] Render AppSwitcher or SettingsSwitcher depending on the navigation

Summary

When we're in settings route, we need to display SettingsSwitcher. In all the other cases, we should do what we were doing up to this point: render the AppSwitcher.
Depends on D3343

Test Plan

Open chat and check if AppSwitcher is rendered. Change path to settings/account and check if SettingsSwitcher is displayed instead.

Diff Detail

Repository

rCOMM Comm

Branch

ENG-445

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Mar 4 2022, 9:26 AM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 4 2022, 9:26 AM

Harbormaster completed remote builds in B7160: Diff 10086.Mar 4 2022, 9:30 AM

tomek requested review of this revision.Mar 4 2022, 9:30 AM

tomek added a child revision: D3345: [web] Render account settings when in right path.Mar 4 2022, 9:37 AM

• benschac accepted this revision.Mar 7 2022, 6:44 AM

This revision is now accepted and ready to land.Mar 7 2022, 6:44 AM

atul accepted this revision.Mar 8 2022, 8:47 AM

Closed by commit rCOMMc99c887f1b8b: [web] Render AppSwitcher or SettingsSwitcher depending on the navigation (authored by tomek). · Explain WhyMar 11 2022, 4:05 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMc99c887f1b8b: [web] Render AppSwitcher or SettingsSwitcher depending on the navigation.

Revision Contents
Changeset List

Path

Size

web/

sidebar/

left-layout-aside.react.js

11 lines

Diff 10086

View Options

web/sidebar/left-layout-aside.react.js

[web] Render AppSwitcher or SettingsSwitcher depending on the navigationClosedPublicActions