Display a password section with a button that allows editing it. The editing will be implemented in one of the future diffs.
https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1272%3A88750
Depends on D3322
Details
Details
- Reviewers
• benschac atul • jacek - Commits
- rCOMM4bd4198b88f4: [web] Add password section
Display a page and check if it is rendered correctly.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/settings/account-settings.react.js | ||
|---|---|---|
| 44 ↗ | (On Diff #10029) | could we use the button component here? |
Comment Actions
My personal preference would be for text to be left-aligned with the header... but what you did matches the Figma designs
Comment Actions
My personal preference would be for text to be left-aligned with the header... but what you did matches the Figma designs
I think the reason for this design was that we would like to have horizontal lines between the items. It would be strange if the text started at the same point as the line. It would be also strange if the lines started earlier than the heading. So my guess is that it would be hard to find a design where we have the separators and the text is aligned with the header.
| web/settings/account-settings.react.js | ||
|---|---|---|
| 44 ↗ | (On Diff #10029) | None of the existing variants work ok here, but after checking our codebase it looks like we should instead use a - we're using it in a couple of similar contexts. |