Paths

Table of Contentst

[web] Address remaining code review comments from D3341
ClosedPublic
Actions

Authored by tomek on Mar 9 2022, 9:55 AM.

Tags

None

Referenced Files

	F3296084: D3388.id10292.diff
	Sun, Nov 17, 12:42 AM

	F3295618: D3388.diff
	Sat, Nov 16, 10:21 PM

	Unknown Object (File)
	Thu, Nov 7, 9:16 AM

	Unknown Object (File)
	Thu, Nov 7, 9:16 AM

	Unknown Object (File)
	Thu, Nov 7, 9:16 AM

	Unknown Object (File)
	Tue, Nov 5, 9:44 PM

	Unknown Object (File)
	Wed, Oct 23, 5:30 AM

	Unknown Object (File)
	Oct 14 2024, 2:18 AM

Subscribers

Details

Reviewers

• benschac
atul
• jacek

Commits

rCOMM2f88cd59f456: [web] Address remaining code review comments from D3341

Summary

Rename activeThreadCurrentlyUnread and delete unused variable
Depends on D3341
Depends on D3387

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Mar 9 2022, 9:55 AM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 9 2022, 9:55 AM

tomek mentioned this in D3341: [web] Make NavigationPanel reusable.Mar 9 2022, 9:55 AM

Harbormaster completed remote builds in B7261: Diff 10232.Mar 9 2022, 10:00 AM

tomek requested review of this revision.Mar 9 2022, 10:00 AM

atul accepted this revision.Mar 9 2022, 10:17 AM

This revision is now accepted and ready to land.Mar 9 2022, 10:17 AM

• benschac accepted this revision.Mar 9 2022, 10:30 AM

tomek added a child revision: D3342: [web] Introduce settings switcher.Mar 11 2022, 1:43 AM

Closed by commit rCOMM2f88cd59f456: [web] Address remaining code review comments from D3341 (authored by tomek). · Explain WhyMar 11 2022, 3:45 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM2f88cd59f456: [web] Address remaining code review comments from D3341.

Revision Contents
Changeset List

Path

Size

web/

sidebar/

app-switcher.react.js

12 lines

Diff 10292

View Options

web/sidebar/app-switcher.react.js

[web] Address remaining code review comments from D3341ClosedPublicActions