Depends on D3416
Put operation in the blob service refactored from sync to async api.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Blob refactor to async API - Remove
Put operation in the blob service refactored from sync to async api.
One of them is wrong - please update the summary.
Also the test plan - can it actually verify that this code works, or is it too early for that and we can only check if it compiles?
| services/blob/docker-server/contents/server/src/BlobServiceImpl.cpp | ||
|---|---|---|
| 233 ↗ | (On Diff #10334) | Is this tracked on Linear somewhere? |
Comment Actions
Abandoning, I'm going to put up a new stack for this which will be hopefully easier to review.
| services/blob/docker-server/contents/server/src/BlobServiceImpl.cpp | ||
|---|---|---|
| 233 ↗ | (On Diff #10334) | |
| services/blob/docker-server/contents/server/src/BlobServiceImpl.cpp | ||
|---|---|---|
| 233 ↗ | (On Diff #10334) | Thanks for linking! Sorry that you had to do it twice, but unfortunately I simply am not going to be able to remember every task on the project, even when I previously ask a question about it. The more you can do to link tasks for follow-ups ahead of time, the less time your reviewers and you will have to spend |