Downstream dependencies have issues surfaced by yarn audit
The repo doesn't have release notes, but skimmed through commits since 1.4.0 and there don't seem to be any breaking changes.
Depends on D3859
Differential D3861
[keyserver] Bump `geoip-lite` to `1.4.5` atul on Apr 27 2022, 8:32 AM. Authored by Tags None Referenced Files
Details Downstream dependencies have issues surfaced by yarn audit The repo doesn't have release notes, but skimmed through commits since 1.4.0 and there don't seem to be any breaking changes. Depends on D3859 CI
Diff Detail
Event TimelineComment Actions Can you also test wherever we use geoip-lite to make sure it still works as expected? You can do this with cd keyserver && yarn update-geoip, but you'll need to create a keyserver/secrets/geoip_license.json file first. comm@server:/var/www/comm$ cat keyserver/secrets/geoip_license.json { "key": "SECRET_KEY_HERE_GET_THIS_FROM_ONE_PASSWORD" } Comment Actions Yeah I'll give that a go. Thanks for the clear instructions, I don't have any context on geoip-lite. Don't have access to 1Password at the moment (don't have work machine), but will test and land once I'm back. Comment Actions Getting the following, it's not exiting and there's no indication it succeeded: edit: added some logging in update-geo-db.js and node_modules/geo-ip/scripts/updatedb.js to try to diagnose... but by time I got back to terminal it looks like it completed. took like 120 seconds which was longer than I'd expect w/o context |