Page MenuHomePhabricator
Differential D3920

[Identity] Set max width to 80 characters
ClosedPublic
Actions

Authored by varun on May 4 2022, 11:32 AM.
Tags
None
Referenced Files
F3391622: D3920.diff
Sat, Nov 30, 4:56 AM
Unknown Object (File)
Fri, Nov 8, 12:47 PM
Unknown Object (File)
Tue, Nov 5, 7:19 PM
Unknown Object (File)
Oct 21 2024, 1:06 PM
Unknown Object (File)
Oct 19 2024, 5:33 AM
Unknown Object (File)
Oct 19 2024, 4:06 AM
Unknown Object (File)
Oct 19 2024, 3:44 AM
Unknown Object (File)
Oct 19 2024, 3:21 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
• karol
tomek
atul
• jim
Commits
rCOMM086389e20728: [Identity] Set max width to 80 characters
Summary

The rustfmt default is 100 characters, but we use 80 in the Comm codebase

Depends on D3853

Test Plan

Ran cargo build

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.May 4 2022, 11:32 AM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptMay 4 2022, 11:32 AM
Harbormaster completed remote builds in B8788: Diff 12236.May 4 2022, 11:37 AM
varun requested review of this revision.May 4 2022, 11:37 AM
varun added a child revision: D3921: [Identity] Implement database client method to get pake registration.May 4 2022, 1:40 PM
• karol accepted this revision.May 5 2022, 3:59 AM
• karol added a reviewer: • jim.
atul accepted this revision.May 5 2022, 4:33 AM
• jim resigned from this revision.May 5 2022, 8:35 AM

Resigning as reviewer b/c I don't condone 80 char line limits. :-P

This revision is now accepted and ready to land.May 5 2022, 8:35 AM
Closed by commit rCOMM086389e20728: [Identity] Set max width to 80 characters (authored by varun). · Explain WhyMay 10 2022, 12:20 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM086389e20728: [Identity] Set max width to 80 characters.
varun added a child revision: D4015: [services][identity] helper function to create primary key for DynamoDB.May 12 2022, 8:06 AM
varun removed a child revision: D3921: [Identity] Implement database client method to get pake registration.May 12 2022, 8:18 AM

Revision Contents
Changeset List

PathSize
services/
identity/
1 line
src/
4 lines
3 lines
12 lines

Diff 12530

View Options

services/identity/rustfmt.toml

Loading...
View Options

services/identity/src/config.rs

Loading...
View Options

services/identity/src/opaque.rs

Loading...
View Options

services/identity/src/service.rs

Loading...