Page MenuHomePhabricator
Differential D4146

[services][identity] helper function to finish pake registration
AbandonedPublic
Actions

Authored by varun on May 27 2022, 10:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 1:27 AM
Unknown Object (File)
Mon, Mar 24, 3:35 AM
Unknown Object (File)
Fri, Mar 21, 5:01 AM
Unknown Object (File)
Thu, Mar 13, 5:11 AM
Unknown Object (File)
Wed, Mar 5, 2:31 PM
Unknown Object (File)
Tue, Mar 4, 9:01 PM
Unknown Object (File)
Jan 17 2025, 8:38 AM
Unknown Object (File)
Jan 16 2025, 5:02 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
• jim
• karol
tomek
Summary

New helper function to finish PAKE registration and put the registration data in DynamoDB

Depends on D4140

Test Plan

successfully stored PAKE registration data in DynamoDB

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.May 27 2022, 10:14 AM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptMay 27 2022, 10:14 AM
Harbormaster completed remote builds in B9511: Diff 13173.May 27 2022, 10:19 AM
varun requested review of this revision.May 27 2022, 10:19 AM
varun added a child revision: D4147: [services][identity] helper function to start pake login.May 27 2022, 11:21 AM
varun updated this revision to Diff 13188.May 27 2022, 1:08 PM

rebase

Harbormaster completed remote builds in B9519: Diff 13188.May 27 2022, 1:15 PM
• karol accepted this revision.May 30 2022, 1:58 AM
This revision is now accepted and ready to land.May 30 2022, 1:58 AM
• karol added 1 blocking reviewer(s): • jim.May 30 2022, 2:11 AM
This revision now requires review to proceed.May 30 2022, 2:11 AM
tomek accepted this revision.May 30 2022, 7:00 AM
tomek added inline comments.
services/identity/src/service.rs
96

Why do we use String here instead of &str? I feel like using &str when we don't need to own or mutate string is more convenient in a function parameter, but maybe it isn't a good practice. @varun is there a good reason for using String here?

• jim accepted this revision.Jun 3 2022, 8:16 AM
• jim added inline comments.
services/identity/src/service.rs
107

nit: Just so you know since Error impls From<DatabaseError>, you don't need the explicit map_err. ? will do that for you.

This revision is now accepted and ready to land.Jun 3 2022, 8:16 AM
varun abandoned this revision.Jun 24 2022, 7:13 AM

Revision Contents
Changeset List

PathSize
services/
identity/
src/
4 lines
27 lines

Diff 13188

View Options

services/identity/src/database.rs

// @flow // @flow
import classNames from 'classnames'; import classNames from 'classnames';
import * as React from 'react'; import * as React from 'react';
import { import useToggleUnreadStatus from 'lib/hooks/toggle-unread-status';
setThreadUnreadStatusActionTypes,
setThreadUnreadStatus,
} from 'lib/actions/activity-actions';
import type {
SetThreadUnreadStatusPayload,
SetThreadUnreadStatusRequest,
} from 'lib/types/activity-types';
import type { ThreadInfo } from 'lib/types/thread-types'; import type { ThreadInfo } from 'lib/types/thread-types';
import {
useServerCall,
useDispatchActionPromise,
} from 'lib/utils/action-utils';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import css from './chat-thread-list.css'; import css from './chat-thread-list.css';
type Props = { type Props = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
+mostRecentNonLocalMessage: ?string, +mostRecentNonLocalMessage: ?string,
+renderStyle?: 'chat' | 'thread', +renderStyle?: 'chat' | 'thread',
}; };
function ChatThreadListItemMenu(props: Props): React.Node { function ChatThreadListItemMenu(props: Props): React.Node {
const { renderStyle = 'chat' } = props; const { renderStyle = 'chat' } = props;
const [menuVisible, setMenuVisible] = React.useState(false); const [menuVisible, setMenuVisible] = React.useState(false);
const toggleMenu = React.useCallback(() => { const toggleMenu = React.useCallback(() => {
setMenuVisible(!menuVisible); setMenuVisible(!menuVisible);
}, [menuVisible]); }, [menuVisible]);
const hideMenu = React.useCallback(() => { const hideMenu = React.useCallback(() => {
setMenuVisible(false); setMenuVisible(false);
}, []); }, []);
const { threadInfo, mostRecentNonLocalMessage } = props; const { threadInfo, mostRecentNonLocalMessage } = props;
const dispatchActionPromise = useDispatchActionPromise(); const toggleUnreadStatus = useToggleUnreadStatus(
const boundSetThreadUnreadStatus: (
request: SetThreadUnreadStatusRequest,
) => Promise<SetThreadUnreadStatusPayload> = useServerCall(
setThreadUnreadStatus,
);
const toggleUnreadStatus = React.useCallback(() => {
const { unread } = threadInfo.currentUser;
const request = {
threadID: threadInfo.id,
unread: !unread,
latestMessage: mostRecentNonLocalMessage,
};
dispatchActionPromise(
setThreadUnreadStatusActionTypes,
boundSetThreadUnreadStatus(request),
undefined,
{
threadID: threadInfo.id,
unread: !unread,
},
);
hideMenu();
}, [
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
dispatchActionPromise,
hideMenu, hideMenu,
boundSetThreadUnreadStatus, );
]);
const toggleUnreadStatusButtonText = `Mark as ${ const toggleUnreadStatusButtonText = `Mark as ${
threadInfo.currentUser.unread ? 'read' : 'unread' threadInfo.currentUser.unread ? 'read' : 'unread'
}`; }`;
const menuIconSize = renderStyle === 'chat' ? 24 : 16; const menuIconSize = renderStyle === 'chat' ? 24 : 16;
const btnCls = classNames(css.menuContent, { const btnCls = classNames(css.menuContent, {
[css.menuContentVisible]: menuVisible, [css.menuContentVisible]: menuVisible,
}); });
Show All 15 Lines
View Options

services/identity/src/service.rs

// @flow // @flow
import classNames from 'classnames'; import classNames from 'classnames';
import * as React from 'react'; import * as React from 'react';
import { import useToggleUnreadStatus from 'lib/hooks/toggle-unread-status';
setThreadUnreadStatusActionTypes,
setThreadUnreadStatus,
} from 'lib/actions/activity-actions';
import type {
SetThreadUnreadStatusPayload,
SetThreadUnreadStatusRequest,
} from 'lib/types/activity-types';
import type { ThreadInfo } from 'lib/types/thread-types'; import type { ThreadInfo } from 'lib/types/thread-types';
import {
useServerCall,
useDispatchActionPromise,
} from 'lib/utils/action-utils';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import css from './chat-thread-list.css'; import css from './chat-thread-list.css';
type Props = { type Props = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
+mostRecentNonLocalMessage: ?string, +mostRecentNonLocalMessage: ?string,
+renderStyle?: 'chat' | 'thread', +renderStyle?: 'chat' | 'thread',
}; };
function ChatThreadListItemMenu(props: Props): React.Node { function ChatThreadListItemMenu(props: Props): React.Node {
const { renderStyle = 'chat' } = props; const { renderStyle = 'chat' } = props;
const [menuVisible, setMenuVisible] = React.useState(false); const [menuVisible, setMenuVisible] = React.useState(false);
const toggleMenu = React.useCallback(() => { const toggleMenu = React.useCallback(() => {
setMenuVisible(!menuVisible); setMenuVisible(!menuVisible);
}, [menuVisible]); }, [menuVisible]);
const hideMenu = React.useCallback(() => { const hideMenu = React.useCallback(() => {
setMenuVisible(false); setMenuVisible(false);
}, []); }, []);
const { threadInfo, mostRecentNonLocalMessage } = props; const { threadInfo, mostRecentNonLocalMessage } = props;
const dispatchActionPromise = useDispatchActionPromise(); const toggleUnreadStatus = useToggleUnreadStatus(
const boundSetThreadUnreadStatus: (
request: SetThreadUnreadStatusRequest,
) => Promise<SetThreadUnreadStatusPayload> = useServerCall(
setThreadUnreadStatus,
);
const toggleUnreadStatus = React.useCallback(() => {
const { unread } = threadInfo.currentUser;
const request = {
threadID: threadInfo.id,
unread: !unread,
latestMessage: mostRecentNonLocalMessage,
};
dispatchActionPromise(
setThreadUnreadStatusActionTypes,
boundSetThreadUnreadStatus(request),
undefined,
{
threadID: threadInfo.id,
unread: !unread,
},
);
hideMenu();
}, [
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
dispatchActionPromise,
hideMenu, hideMenu,
boundSetThreadUnreadStatus, );
]);
const toggleUnreadStatusButtonText = `Mark as ${ const toggleUnreadStatusButtonText = `Mark as ${
threadInfo.currentUser.unread ? 'read' : 'unread' threadInfo.currentUser.unread ? 'read' : 'unread'
}`; }`;
const menuIconSize = renderStyle === 'chat' ? 24 : 16; const menuIconSize = renderStyle === 'chat' ? 24 : 16;
const btnCls = classNames(css.menuContent, { const btnCls = classNames(css.menuContent, {
[css.menuContentVisible]: menuVisible, [css.menuContentVisible]: menuVisible,
}); });
Show All 15 Lines