Paths

Table of Contentst

Differential D4146

[services][identity] helper function to finish pake registration
AbandonedPublic
Actions

Authored by varun on May 27 2022, 10:14 AM.

Tags

None

Referenced Files

	F3113813: D4146.id13188.diff
	Thu, Oct 31, 7:26 PM

	F3112343: D4146.diff
	Thu, Oct 31, 5:18 PM

	Unknown Object (File)
	Wed, Oct 23, 5:28 AM

	Unknown Object (File)
	Mon, Oct 21, 1:43 AM

	Unknown Object (File)
	Sat, Oct 19, 12:33 PM

	Unknown Object (File)
	Sat, Oct 19, 12:33 PM

	Unknown Object (File)
	Sat, Oct 19, 12:33 PM

	Unknown Object (File)
	Thu, Oct 17, 10:44 AM

Subscribers

Details

Reviewers

• jim
• karol
tomek

Summary

New helper function to finish PAKE registration and put the registration data in DynamoDB

Depends on D4140

Test Plan

successfully stored PAKE registration data in DynamoDB

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.May 27 2022, 10:14 AM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptMay 27 2022, 10:14 AM

Harbormaster completed remote builds in B9511: Diff 13173.May 27 2022, 10:19 AM

varun requested review of this revision.May 27 2022, 10:19 AM

varun added a child revision: D4147: [services][identity] helper function to start pake login.May 27 2022, 11:21 AM

rebase

Harbormaster completed remote builds in B9519: Diff 13188.May 27 2022, 1:15 PM

• karol accepted this revision.May 30 2022, 1:58 AM

This revision is now accepted and ready to land.May 30 2022, 1:58 AM

• karol added 1 blocking reviewer(s): • jim.May 30 2022, 2:11 AM

This revision now requires review to proceed.May 30 2022, 2:11 AM

tomek accepted this revision.May 30 2022, 7:00 AM

tomek added inline comments.

services/identity/src/service.rs
96	Why do we use `String` here instead of `&str`? I feel like using `&str` when we don't need to own or mutate string is more convenient in a function parameter, but maybe it isn't a good practice. @varun is there a good reason for using `String` here?

• jim accepted this revision.Jun 3 2022, 8:16 AM

• jim added inline comments.

services/identity/src/service.rs
107	nit: Just so you know since `Error` impls `From<DatabaseError>`, you don't need the explicit `map_err`. `?` will do that for you.

This revision is now accepted and ready to land.Jun 3 2022, 8:16 AM

varun abandoned this revision.Jun 24 2022, 7:13 AM

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

4 lines

27 lines

Diff 13188

services/identity/src/database.rs

Loading...

services/identity/src/service.rs

Loading...