Page MenuHomePhabricator
Differential D4275

[services] Tests - Blob - Add Get
ClosedPublic
Actions

Authored by • karol on Jun 15 2022, 3:10 AM.
Tags
None
Referenced Files
F3502165: D4275.id14077.diff
Fri, Dec 20, 3:58 AM
F3499642: D4275.diff
Thu, Dec 19, 11:48 PM
F3497117: D4275.id.diff
Thu, Dec 19, 6:05 PM
Unknown Object (File)
Mon, Dec 16, 7:18 AM
Unknown Object (File)
Mon, Dec 16, 7:18 AM
Unknown Object (File)
Mon, Dec 16, 7:18 AM
Unknown Object (File)
Sun, Dec 15, 11:49 AM
Unknown Object (File)
Tue, Nov 26, 10:56 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
varun
Commits
rCOMM23ee43573ca0: [services] Tests - Blob - Add Get
Summary

Depends on D4274

Adding Get method to blob's tests.

Test Plan

For now, this method's not invoked. The Rust project should build normally.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Jun 15 2022, 3:10 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 15 2022, 3:10 AM
Harbormaster completed remote builds in B9766: Diff 13518.Jun 15 2022, 3:39 AM
• karol requested review of this revision.Jun 15 2022, 3:39 AM
• karol mentioned this in D4277: [services] Tests - Blob - Add test logic.Jun 15 2022, 4:28 AM
• karol edited the summary of this revision. (Show Details)Jun 15 2022, 4:35 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a parent revision: D4274: [services] Tests - Blob - Add Put.
• karol added reviewers: tomek, varun.
• karol added a child revision: D4276: [services] Tests - Blob - Add Remove.
tomek accepted this revision.Jun 20 2022, 5:58 AM
varun accepted this revision.Jun 21 2022, 8:36 PM
varun added inline comments.
services/commtest/tests/blob/get.rs
6–10

nit: it looks better to have all your 3P use statements together, and then all your crate use statements

This revision is now accepted and ready to land.Jun 21 2022, 8:36 PM
varun mentioned this in D4276: [services] Tests - Blob - Add Remove.Jun 21 2022, 8:39 PM
• karol updated this revision to Diff 14077.Jul 1 2022, 2:42 AM
• karol edited the summary of this revision. (Show Details)

group uses

Harbormaster completed remote builds in B10199: Diff 14077.Jul 1 2022, 2:54 AM
Closed by commit rCOMM23ee43573ca0: [services] Tests - Blob - Add Get (authored by • karol). · Explain WhyJul 8 2022, 2:30 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM23ee43573ca0: [services] Tests - Blob - Add Get.
• karol mentioned this in rCOMMa531a7b440e3: [services] Tests - Blob - Add test logic.

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
blob/
30 lines

Diff 13518

View Options

services/commtest/tests/blob/get.rs

Loading...