Ran the code analysis tool in IDE which surfaced some misc CSS issues. I'll label each issue inline.
Depends on D4338
Details
Details
NA, careful reading
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- june21 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| landing/info-block.css | ||
|---|---|---|
| 31 | We should include a fallback font here. In this case sans-serif | |
| 31 ↗ | (On Diff #13694) | W |
| 31 ↗ | (On Diff #13694) | We should include a fallback here |
| landing/subscription-form.css | ||
| 10 | Properties could be collapsed into single line | |
| web/components/menu.css | ||
| 41 | background-color and color were included twice (with the same values each time) | |
| web/theme.css | ||
| 129 | Typo, --shades-of-white-60 doesn't exist | |
| landing/subscription-form.css | ||
|---|---|---|
| 10 | Don't need units for 0. Read more: https://stackoverflow.com/q/7923042/13079675 | |
| 65 | ||
| landing/info-block.css | ||
|---|---|---|
| 31 | Created a task: https://linear.app/comm/issue/ENG-1293/define-something-like-font-stack-on-web and added to backlog. | |
| landing/subscription-form.css | ||
| 10 | Saw that this was handled on another diff | |
| web/theme.css | ||
| 129 | It looks like it fixes an issue. Before:  After:  Before this fix, the active thread text was 100% white (255,255,255) which made it look unread. This fixes the styling for active && read threads. | |
Comment Actions
FYI, I can't see the images in this inline comment. I ran into a similar issue when reviewing another diff, so maybe this is an issue where images don't show up on inline comments.
Edit:
Ah, after you rebased now I can see the images:
{F82863}
This can probably be disregarded, then.