Page MenuHomePhabricator

[web] [landing] Omit units for 0 values in CSS
ClosedPublic

Authored by abosh on Jun 23 2022, 8:36 AM.
Tags
None
Referenced Files
F2110464: D4343.id13713.diff
Tue, Jun 25, 7:59 PM
Unknown Object (File)
Fri, Jun 21, 1:30 AM
Unknown Object (File)
Mon, Jun 17, 4:39 AM
Unknown Object (File)
Mon, Jun 17, 12:28 AM
Unknown Object (File)
Mon, Jun 17, 12:28 AM
Unknown Object (File)
Mon, Jun 17, 12:28 AM
Unknown Object (File)
Mon, Jun 17, 12:28 AM
Unknown Object (File)
Sat, Jun 15, 6:58 PM
Subscribers

Details

Summary

The units for 0 values in CSS are redundant. This is a quick no-op change that makes the code more concise and readable as the unitless 0 is distinguished from hard-set values with units.

Read more: https://stackoverflow.com/q/7923042/13079675


This technically depends on D4339 since both diffs modify landing/subscription-form.css, but I can resolve that merge conflict quickly and easily.

Test Plan

Find-and-replace + close reading. 0px == 0 in CSS, so there are no style changes that can occur as a result of this.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable