Details

services/commtest/tests/blob/put.rs
41	this somehow doesn't work even though it works with the inner scope, this is apparently a different case with all the generators and stuff. Rust is really silent about the generators, as Varun mentioned they are relatively new to the language.
41	I'm going to revert this, we can create a follow-up about this, I couldn't hack it and I have no idea how can I make it work. @varun ?

revert the state change

Harbormaster failed remote builds in B10099: Diff 13960!Jun 29 2022, 6:01 AM

The problem is I couldn't figure out how to modify anything inside of the generator's body:

let mut x = 0;
let outbound = async_stream::stream! {
  //...
  x += 1;
  //...
};
println!("=> {}", x);

The output would still be 0. I tried borrowing, using Arc (can Rc/Arc be mutated at all?), but nothing worked.
This has to be generator-specific stuff, but generators are not well documented afaik.

Something like this works like a charm:

let mut b = false;
{
  b = true;
};
println!("hey {}", b); // true

@varun

i'll try to play around with this tomorrow

In D4274#124268, @karol-bisztyga wrote:
The problem is I couldn't figure out how to modify anything inside of the generator's body:
let mut x = 0;
let outbound = async_stream::stream! {
  //...
  x += 1;
  //...
};
println!("=> {}", x);
The output would still be 0. I tried borrowing, using Arc (can Rc/Arc be mutated at all?), but nothing worked.
This has to be generator-specific stuff, but generators are not well documented afaik.

Something like this works like a charm:
let mut b = false;
{
  b = true;
};
println!("hey {}", b); // true
@varun

That's strange... one possible option might be to try Rc<RefCell<T>>, but there should be an easier way.

I'm going to revert this, we can create a follow-up about this, I couldn't hack it and I have no idea how can I make it work. @varun ?

Didn't have time to investigate the generator thing, and honestly not sure I'll get to it tomorrow either. Can you please create a follow-up task in Linear? You can assign it to me

This revision is now accepted and ready to land.Jun 30 2022, 2:58 PM

https://linear.app/comm/issue/ENG-1366/figure-out-modifying-variables-inside-of-the-rusts-generator

This revision was landed with ongoing or failed builds.Jul 8 2022, 2:30 AM

Closed by commit rCOMM8810a366fdc6: [services] Tests - Blob - Add Put (authored by • karol). · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM8810a366fdc6: [services] Tests - Blob - Add Put.

• karol mentioned this in rCOMMa531a7b440e3: [services] Tests - Blob - Add test logic.