Page MenuHomePhabricator
Differential D4396

Introduce flat-file based message storage and its utilities to XCode build system
AbandonedPublic
Actions

Authored by marcin on Jun 29 2022, 2:48 AM.
Tags
None
Referenced Files
F3560209: D4396.id13959.diff
Fri, Dec 27, 7:12 AM
F3560208: D4396.id13958.diff
Fri, Dec 27, 7:12 AM
F3560207: D4396.id13930.diff
Fri, Dec 27, 7:12 AM
F3560114: D4396.id.diff
Fri, Dec 27, 7:11 AM
F3560049: D4396.diff
Fri, Dec 27, 7:03 AM
Unknown Object (File)
Mon, Dec 16, 10:03 AM
Unknown Object (File)
Mon, Dec 16, 10:03 AM
Unknown Object (File)
Mon, Dec 16, 10:03 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
tomek
varun
• karol
Summary

Trigger XCode compilation of flat-file message storage and its utilities.

Test Plan

No test plan

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-1218
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jun 29 2022, 2:48 AM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJun 29 2022, 2:48 AM
marcin added a parent revision: D4395: Implement sanity check for semaphore for flat-file based message storage.Jun 29 2022, 2:54 AM
Harbormaster completed remote builds in B10076: Diff 13930.Jun 29 2022, 3:03 AM
marcin requested review of this revision.Jun 29 2022, 3:03 AM
marcin updated this revision to Diff 13958.Jun 29 2022, 5:26 AM

Rebase with master

Harbormaster failed remote builds in B10097: Diff 13958!Jun 29 2022, 5:27 AM
marcin updated this revision to Diff 13959.Jun 29 2022, 5:37 AM

Fix bugs in project.pbxproj after rebasing onto master

Harbormaster completed remote builds in B10098: Diff 13959.Jun 29 2022, 5:49 AM
tomek requested changes to this revision.Jun 30 2022, 4:32 AM

It's probably better to add files to project.pbxproj as they are introduced (in the same diff) - by doing that we will make sure that we're not adding something that doesn't compile

This revision now requires changes to proceed.Jun 30 2022, 4:32 AM
ashoat added a comment.Jun 30 2022, 6:45 AM

(Agree with @palys-swm)

marcin abandoned this revision.Jul 5 2022, 4:43 AM

All files are immediately introduced to XCode in differentials that create them.

Revision Contents
Changeset List

PathSize
native/
ios/
Comm.xcodeproj/
30 lines

Diff 13958

View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...