Introduce flat-file based message storage and its utilities to XCode build system
AbandonedPublic
Actions

Authored by marcin on Jun 29 2022, 2:48 AM.

Details

Reviewers

tomek
varun
• karol

Summary

Trigger XCode compilation of flat-file message storage and its utilities.

Test Plan

No test plan

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-1218

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Jun 29 2022, 2:48 AM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJun 29 2022, 2:48 AM

marcin added a parent revision: D4395: Implement sanity check for semaphore for flat-file based message storage.Jun 29 2022, 2:54 AM

Harbormaster completed remote builds in B10076: Diff 13930.Jun 29 2022, 3:03 AM

marcin requested review of this revision.Jun 29 2022, 3:03 AM

Rebase with master

Harbormaster failed remote builds in B10097: Diff 13958!Jun 29 2022, 5:27 AM

Fix bugs in project.pbxproj after rebasing onto master

Harbormaster completed remote builds in B10098: Diff 13959.Jun 29 2022, 5:49 AM

It's probably better to add files to project.pbxproj as they are introduced (in the same diff) - by doing that we will make sure that we're not adding something that doesn't compile

This revision now requires changes to proceed.Jun 30 2022, 4:32 AM

(Agree with @palys-swm)

All files are immediately introduced to XCode in differentials that create them.

Revision Contents
Changeset List

Path

Size

native/

ios/

Comm.xcodeproj/

project.pbxproj

32 lines

Diff 13930

View Options

native/ios/Comm.xcodeproj/project.pbxproj

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };

Introduce flat-file based message storage and its utilities to XCode build systemAbandonedPublicActions