Paths

Table of Contentst

Differential D4324

[services] Backup - Fix dynamoDB item size limit
ClosedPublic
Actions

Authored by • karol on Jun 22 2022, 3:31 AM.

Tags

None

Referenced Files

	F2907809: D4324.id14346.diff
	Sun, Oct 6, 12:21 PM

	F2907798: D4324.id14317.diff
	Sun, Oct 6, 12:17 PM

	F2907758: D4324.id13932.diff
	Sun, Oct 6, 12:01 PM

	Unknown Object (File)
	Fri, Oct 4, 4:01 AM

	Unknown Object (File)
	Wed, Oct 2, 5:28 AM

	Unknown Object (File)
	Fri, Sep 27, 11:47 AM

	Unknown Object (File)
	Fri, Sep 27, 6:16 AM

	Unknown Object (File)
	Wed, Sep 25, 11:38 AM

Subscribers

Details

Reviewers

tomek
ashoat
varun

Commits

rCOMMd9e41f608557: [services] Backup - Fix dynamoDB item size limit

Summary

Depends on D4323

linear task: https://linear.app/comm/issue/ENG-1288/properly-handle-the-dynamodb-item-size-limit

Finally, the proper value that is 400KiB (400 * 1024) (not KB) based on the research described in the linked task.

Test Plan

-

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Jun 22 2022, 3:31 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 22 2022, 3:31 AM

Harbormaster completed remote builds in B9873: Diff 13658.Jun 22 2022, 3:55 AM

• karol requested review of this revision.Jun 22 2022, 3:55 AM

• karol edited the summary of this revision. (Show Details)Jun 22 2022, 6:27 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, ashoat.

• karol added a parent revision: D4323: [services] Backup - Update add attachments logic.

• karol added a child revision: D4325: [services] Tests - Backup - Add dynamoDB item size limit.

ashoat mentioned this in D4233: [services] Backup - Fix data size database limit.Jun 22 2022, 11:09 AM

ashoat accepted this revision.Jun 22 2022, 11:25 AM

This revision is now accepted and ready to land.Jun 22 2022, 11:25 AM

rebase

Harbormaster failed remote builds in B10049: Diff 13889!Jun 28 2022, 5:37 AM

rebase

Harbormaster failed remote builds in B10078: Diff 13932!Jun 29 2022, 2:55 AM

use functions with scope

There's a lot more going on here than when I initially accepted. Would love if @palys-swm could take a pass

This revision now requires review to proceed.Jun 30 2022, 6:49 AM

ashoat added a reviewer: varun.Jun 30 2022, 6:49 AM

tomek accepted this revision.Jun 30 2022, 7:28 AM

tomek added inline comments.

services/commtest/tests/backup_test.rs
47 ↗	(On Diff #14033)	Please reformat the code - some lines seem to be too long
134 ↗	(On Diff #14033)	I suggested this somewhere: we should avoid magic numbers like this and instead give them meaningful names. Also, if the variables depend on each other, one should be computed based on the other.
153 ↗	(On Diff #14033)	`assert_eq`

This revision is now accepted and ready to land.Jun 30 2022, 7:28 AM

Harbormaster failed remote builds in B10163: Diff 14033!Jun 30 2022, 8:42 AM

Harbormaster completed remote builds in B10163: Diff 14033.Jun 30 2022, 8:47 AM

• karol added inline comments.Jul 8 2022, 1:44 AM

services/commtest/tests/backup_test.rs
134 ↗	(On Diff #14033)	this is resolved in D4326 these changes are going to be landed together anyway

address feedback

Harbormaster failed remote builds in B10407: Diff 14317!Jul 8 2022, 1:46 AM

• karol added a child revision: D4326: [services] Tests - Update backup test.Jul 8 2022, 1:50 AM

• karol removed a child revision: D4325: [services] Tests - Backup - Add dynamoDB item size limit.

This revision was landed with ongoing or failed builds.Jul 8 2022, 2:31 AM

Closed by commit rCOMMd9e41f608557: [services] Backup - Fix dynamoDB item size limit (authored by • karol). · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMd9e41f608557: [services] Backup - Fix dynamoDB item size limit.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

4 lines

commtest/

tests/

73 lines

lib/

10 lines

Diff 14346

services/backup/src/Constants.h

Loading...

services/commtest/tests/backup_test.rs

Loading...

services/commtest/tests/lib/tools.rs

Loading...